Repository navigation
Labs show the bucket and role they rely on - #83
Merged
Merged
Conversation
The account-hardening access-analyzer step put a policy on a bucket its commands never created (and that Block Public Access would refuse), and the machine-identity ABAC step put a policy on a role its commands never created. Both now show the create lines, so a learner pasting them doesn't hit not found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Chris
Two steps used a resource that their own commands never created. A learner pasting only those commands would hit "not found". The live replay for PR #82 found both, and Chris approved adding the lines.
aws s3api create-bucketforlab-hardening-shared-reports. It also addsdelete-public-access-block, because on real AWS, Block Public Access refuses the public-read policy the step puts on the bucket.aws iam create-roleforlab-identity-abac, with a trust policy that allowssts:AssumeRoleandsts:TagSession, which the--tagsassume-role needs.The backend steps already created both resources, so the steps' own behaviour is unchanged.
Tests
python manage.py test --noinput dashboard.tests_labs: 276 pass, including the CLI parser and shell-quoting checks from PR Fix lab CLI lines and Python/Terraform snippets found by replaying every lab #82ruff check .: clean🤖 Generated with Claude Code