Repository navigation
CloudFormation inventory: an unreadable stack policy is a Floci gap - #81
Merged
Merged
Conversation
Floci 2.4.0 answers GetStackPolicy without a GetStackPolicyResult element, so boto3 raises KeyError and every stack's inventory carried an error, failing dashboard.integration_tests whenever a stack exists. Report it as unavailable. Floci's main branch already returns stored policies (floci-io/floci#7552). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
returnvalue
force-pushed
the
claude/cfn-stack-policy-gap
branch
from
November 7, 2026 19:04
964ba32 to
6b0b443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Chris
What broke
dashboard.integration_testsfailed on Floci 2.4.0 whenever any CloudFormation stack existed:cloudformation: 'GetStackPolicyResult'. CI never sees it because its Floci has no stacks.Floci 2.4.0 answers
GetStackPolicywith an empty<GetStackPolicyResponse>(noGetStackPolicyResult), with or without a policy set, so boto3 raisesKeyError. Floci'smainalready stores and returns stack policies (floci-io/floci#7552, 2026-11-05), not released yet.Fix
The inventory reports that case as
{'unavailable': ...}(a Floci gap) instead of an error. Other failures still surface as errors. The console doesn't display this field, so nothing changes on screen.Checks
ruff check .clean.dashboard.integration_testsagainst a throwaway Floci 2.4.0 with a stack present: 19/19 pass (was 18/19).🤖 Generated with Claude Code