Refactor implementation for set_dhcp - #534
Open
fabi200123 wants to merge 1 commit into
Open
fabi200123 wants to merge 1 commit into
fabi200123 wants to merge 1 commit into
Conversation
fabi200123
force-pushed
the
fix-set-dhcp
branch
from
September 28, 2026 09:51
e4d75fa to
dd62de7
Compare
fabi200123
marked this pull request as ready for review
September 28, 2026 10:01
Dany9966
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the current logic of how
set_dhcpis being set and used across. Prior to this PR, the implementation used 2 differentset_dhcpoptions, which caused confusion:The one from
osmorphing_parameterswas not implemented by all providers, while thenics_set_dhcpfromosmorphing_infois already on all providers (including those that also added theosmorphing_parametersone.Now, with this PR I have updated the implementation to drop the
osmorphing_parameters.set_dhcpoption in favor ofosmorphing_info.nics_set_dhcp.