Repository navigation
android: Update track subtitles based on context - #28
Merged
Merged
Conversation
Artist pages showed track artist instead of album artist, while album pages repeated the album title in every track row. Allow callers to override PlaylistMemberRow subtitles. Artist pages now show album artist and album, falling back to track artist when needed; album pages show track artist only. Other callers retain their existing subtitles. Verified with :app:assembleDebug through the managed Gradle wrapper and installation on a USB phone. Both views were visually confirmed by the user. Unit tests were not run.
The new album-artist subtitle formatter lacked automated coverage for metadata precedence and missing fields. Add tests for album-artist precedence, track-artist fallback, blank-field separator handling, and unchanged track-artist formatting. Verified :app:testDebugUnitTest through the managed Gradle wrapper and git diff --check. All checks passed.
Member
|
Perfect! thank you robert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make local-library track subtitles specific to the current view:
Adds an optional subtitle parameter to
PlaylistMemberRow; other views remain unchanged.Verification
:app:assembleDebugpassed.:app:testDebugUnitTestpassed, including new coverage for artist precedence, fallback, blank fields, and unchanged existing formatting.