Skip to content

chore(repo): emit local declaration maps for go-to-source - #9676

Open
Ephem wants to merge 1 commit into
fredrik/improve-typecheck-2from
fredrik/source-definitions
Open

chore(repo): emit local declaration maps for go-to-source#9676
Ephem wants to merge 1 commit into
fredrik/improve-typecheck-2from
fredrik/source-definitions

Conversation

@Ephem

@Ephem Ephem commented Sep 7, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes click-to-src by emitting sourcemaps that are ignored in the npm pack.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Stack created with GitHub Stacks CLIGive Feedback 💬

@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 7, 2026 7:15pm UTC
swingset Ready Ready Preview Sep 7, 2026 7:15pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 24483c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 6a53e9d7-f0d8-4f44-999d-32bf2d7cbaae

📥 Commits

Reviewing files that changed from the base of the PR and between 3303058 and 24483c6.

📒 Files selected for processing (1)
  • packages/ui/tsdown.config.mts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)

Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

Declaration builds now generate declaration sourcemaps across multiple packages. Published package contents exclude .d.ts.map and .d.mts.map files. VS Code enables source-definition navigation. An empty Changeset metadata block is added.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 24483

The declaration sourcemap configuration change has no substantiated merge-blocking risk.

Suggested reviewers: alexcarpenter

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: emitting local declaration maps to support go-to-source navigation.
Description check ✅ Passed The description directly explains the click-to-source fix and the use of sourcemaps excluded from npm packages.

Warning

Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed clerk/clerk_go, clerk/dashboard, clerk/accounts, clerk/backoffice, clerk/clerk, skipped clerk/clerk-docs, clerk/cloudflare-workers.


Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9676

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9676

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9676

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9676

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9676

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9676

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9676

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9676

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9676

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9676

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9676

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9676

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9676

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9676

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9676

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9676

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9676

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9676

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9676

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9676

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9676

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9676

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9676

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9676

commit: 24483c6

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-07T19:19:22.337Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 24483c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant