fix loading code file with '>>>' string - #560
Conversation
|
That makes sense because it goes through serial for that device, which uses circuitpython-repl-js. It needs to be more reliable because this is the favored way to open files. |
|
I don't think this is the correct fix because in certain situations, you want the text to be returned only and not the raw file. I need to look further, but the correct fix likely needs to be in https://github.com/adafruit/circuitpython-repl-js with mechanisms to only look for >>> in the right situations. |
|
I traced this to the raw REPL response parser and opened adafruit/circuitpython-repl-js#25 with a fix and regression tests.
With that fixed in the library, this web-editor change should not need to route all text reads through the binary/base64 path and |
|
Closing in favor of adafruit/circuitpython-repl-js#25 and #561. |
|
The root-cause fix should be live in a couple minutes if you'd like to give it a test. |
This fixes an issue that causes opening a file to fail if the file contains ">>>" in a string. I believe that some part of the logic is getting that confused for the REPL prompt even if it is in a string literal.
Fixed by transferring the contents of the file in base64 instead of raw.
Thested successfully on a ESP32-C6 with by opening a file that contains
print("hello >>> world")