Repository navigation
Conversation
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
Contributor
Mutation testing (cargo-mutants,
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stored record validation needs to distinguish errors visible before key retrieval from type mismatches concealed inside authenticated ciphertext. This adds the experimental
record-reads-v1profile with 26 cases shared by native Rust and Go WASI.Cases cover malformed rows and output maps, missing ciphertext, plaintext under
c, late batch failures, authenticated type mismatches, null read-policy changes, and context-field preflight. Reads also explicitly preserve the existing projection behavior: extra fields/outputs and missing equality terms do not prevent opening ciphertext.Native tests assert the shape/pending stage, complete diagnostic payloads, and data-key retrieval counts. Go runs every case through an uninitialised guest and an active guest, proving malformed inputs fail before cipher lookup while concealed type mismatches pass preflight. Representable cases additionally exercise
Cipher.Open. A test-only tree entry point reaches the existing guest export for shapes the record adapter cannot express; it uses the existing codec and buffer cleanup.The contract records the existing diagnostic difference for a static-context plan given a call context:
check_recordreports a generic dynamic-record refusal, while the native pending opener names both context sources. The roadmap and coverage map identify overlap with current tests and the assertions they retain. No existing tests are removed. Repeated-key/raw-leaf framing, broader context composition, EQL/JSON profiles, and Python/TypeScript consumers remain follow-ups.Stack: #1404 → #1460 → #1461 → this PR. Review against
feat/stack-encrypt-runtime-conformance; merge the parents first and retarget as they land.Validation: all four profiles (275 shared cases) and fresh scalar Go-to-Rust exchange pass locally; Rust clippy/formatting, Go lint, Biome and 34 CI wiring checks pass. The deterministic guest is reused from the unchanged parent engine. Native call counts are observed; Go logical provider-call counts are not claimed. No credentials or database required. Test/docs/tooling changes only; no release changeset.