Repository navigation
Add French, Spanish (ES/MX), Portuguese and Italian translations - #14
Merged
Merged
Conversation
Five more locales, each complete against the current 452-key set and each verified by tools/locale-lint.ps1: no orphaned keys, no format-specifier mismatches, no duplicates, all registered in the TOC. esMX is derived from esES rather than hand-copied. The two Blizzard localizations differ in scattered vocabulary rather than in structure, and deriving it means the key set cannot silently drift out of step with esES; genuine regional overrides can be appended below the shared block. None of these has been reviewed by a native speaker. Terminology follows each client's own wording where it exists, and every file says so in its header and points at the issue tracker, so a wrong string reads as an invitation to correct it rather than as authoritative. Russian, Korean and both Chinese locales are deliberately left out. The addon hardcodes Fonts\FRIZQT__.TTF in ten places and Blizzard ships locale-specific fonts for those clients, so a translation would likely render as empty boxes. A translation nobody can read is worse than English, so that has to be fixed first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five more locales, taking StatPanel from one translation to six. Each is complete against the current 452-key set.
frFResESesMXptBRitITAll six (including the existing
deDE) passtools/locale-lint.ps1with no errors — no orphaned keys, no format-specifier mismatches, no duplicates, every file registered in the TOC with a matchingSP.Localeargument.esMX is derived, not copied
esMX.luais generated fromesES.luawith the header and locale argument swapped. The two Blizzard localizations differ in scattered vocabulary rather than in structure, and deriving it means the key set cannot silently drift out of step with esES. Genuine regional overrides can be appended below the shared block.These have not been reviewed by native speakers
Terminology follows each client's own wording where it exists —
Maîtrise/Polyvalence,Maestría/Versatilidad,Maestria/Versatilidade,Maestria/Versatilità— but I can't vouch for tone across 2,260 strings.Every file says so in its header and points at the issue tracker, so a wrong string reads as an invitation to correct it rather than as authoritative.
Locales/README.mdsays the same thing.If long-term translation quality matters, the better answer is CurseForge's localization system: the packager already supports
@localization@substitution and the project already hasX-Curse-Project-ID, so real players could correct these in place. Happy to wire that up separately.Why no Russian, Korean or Chinese
Fonts\FRIZQT__.TTFis hardcoded in ten places across Options.lua, Widgets.lua and Media.lua — whose comment claims "Blizzard ships these with every client and locale." Those clients use locale-specific font files, so a translation would likely render as empty boxes rather than text.I have not been able to verify this without those clients, so it's a strong suspicion rather than a confirmed finding. Either way it needs resolving before those locales are worth adding — a translation nobody can read is worse than English.
Still open
string.format("%.2f")always emits10.65; French, Spanish, Portuguese and Italian all use a decimal comma. The token examples in these files say10.65to match what the code actually renders, rather than promising a comma it won't produce.%-12sin the gear report pads by bytes, so accented slot names skew that column.