Repository navigation
ci: make golangci-lint v2 pass for the Go 1.26.10 bump - #981
Open
fraseragain wants to merge 1 commit into
Open
fraseragain wants to merge 1 commit into
fraseragain wants to merge 1 commit into
Conversation
- stop enforcing staticcheck quick-fix suggestions (QF1007, QF1008, QF1012), which golangci-lint v2 now reports - exclude goconst for test helpers under tests/ and for oracle store migrations, which list exchange and denom names as data - gofumpt: drop redundant parentheses in five files (no behaviour change) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Targets #980 (Go 1.26.10 and golangci-lint v2). Its only failing check is "Lint / Golang", with 46 issues; this brings it to zero without changing chain logic.
checks, alongside the existing-ST1003.tests/; v1 ignored tests and the v2 rule only covered_test.go. 15 are exchange and denom names inx/oracle/keeper/migrations.go, which are migration data and should stay literal. Both paths are now excluded for goconst only.(sdk.Coins)(nil)→sdk.Coins(nil)and(int64)(x)→int64(x). These are formatting only, with no change to behaviour, including inante/tx_msg_filters.goandx/oracle/keeper/reward.go.How it was tested
golangci-lint run(v2.15.0, same config): 0 issues. It was 46 on chore: Bump go #980.go build ./...on golang:1.26.10: OK.go test ./ante/... ./x/oracle/keeper/...on golang:1.26.10: both packages pass.Review notes
tests/restores the v1 behaviour, so it is not a loosening. The oracle migrations exclusion is file-specific.Part of the October 2026 security remediation (tracker items S-013 and S-021).
🤖 Generated with Claude Code