Repository navigation
Conversation
…p [RED-1289] validate, test and deploy now fail with an error for a SlackAppAlertChannel with Slack destinations when the account reports, through the account's new connectedIntegrations, that the Checkly Slack app is not connected. Its alerts cannot be delivered, including for a channel deployed before the app was disconnected, and a warning in CI output goes unseen. The check is skipped when the API does not report connected integrations. The advanced project templates no longer construct a Slack app channel, so a freshly created project validates on an account without the app, and the agent guidance that recommends the construct says it needs one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
checkly validate,testanddeploy(and every other command that validates the project, such aspw-testandimport plan) now fail for aSlackAppAlertChannelwith Slack destinations when the account has no Checkly Slack app connected:It's an error rather than a warning on purpose. A Slack App channel without the app delivers nothing, and that includes a channel deployed before the app was disconnected. A warning printed in CI output goes unseen.
How it works
connectedIntegrations.AuthCommandstores it inSessionnext toaccountFeatures, along with the account ID used for the link.SlackAppAlertChannel.validate()adds the error when the field is present and lacksSLACK. When the API doesn't send the field (older or self-hosted backends), the check is skipped.checkly teston any account without the app.SlackAppAlertChannelnow says it needs the app.Notes for the Reviewer
connectedIntegrationsto the account routes. It isn't merged or deployed yet. Merging this first is safe, because the check stays off until the backend sends the field. In practice it takes effect once both the backend deploy and a CLI release are out.testanddeploy, including a deploy that leaves the channel unchanged, which Checkly itself would accept. This PR doesn't use the!marker that previous changes like this used in 10.0.0. Decide whether it should be marked breaking.SLACKreflects what Checkly has stored. An app uninstalled on the Slack side still reads as connected.Testing
src/constructs/__tests__/slack-app-alert-channel.spec.tscovers four cases:The construct, command and REST suites pass (1,784 tests) and
tsc -p tsconfig.json --noEmitis clean. No test covers the wiring fromAuthCommandintoSession, as foraccountFeatures.🤖 Generated with Claude Code