Repository navigation
[pull] master from microsoft:master - #151
Merged
Merged
Conversation
Document payload publishing, named runner arguments, and local service path resolution. Warn about stale outputs and shared functional-test resources. Assisted-by: GPT-5.6 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
docs(agents): clarify functional test dev workflow
PR validation builds on the arm64 runner intermittently fail with `C3859: Failed to create virtual memory for PCH` while building one of the native hook projects (e.g. GVFS.PostIndexChangedHook). This is a transient cl.exe failure caused by memory pressure on the build host, not a problem with the code being built, and the same build reliably succeeds on a manual re-run. Build.bat now retries each native vcxproj build (GitHooksLoader, GVFS.NativeTests, GVFS.PostIndexChangedHook, GVFS.ReadObjectHook, GVFS.VirtualFileSystemHook) up to 3 times, with a short delay between attempts, before failing the build. This removes the need for a human to notice the failure and manually re-run the pipeline. Assisted-by: GitHub Copilot Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
The previous commit retried a native vcxproj build on any MSBuild failure, which would also retry (and mask, and waste time on) a real compile error introduced by a code change. Capture each attempt's output and only retry when the log actually contains the transient C3859 "Failed to create virtual memory for PCH" error; any other failure now fails immediately on the first attempt. Assisted-by: GitHub Copilot Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Retry native C++ project builds on transient MSBuild PCH failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )