Repository navigation
Fix release assets upload on version PRs - #249
Merged
Merged
Conversation
On pull_request events github.ref_name is "<n>/merge", so the upload step had no tag and failed after the release was created (seen on certego/django-fernet 0.1.1). pypanoptikon already carries this patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Make
_release_and_tag.ymlattach the sdist and wheel to the release it creates whenappend_to_release: true.Why
The workflow runs on
pull_request: closed, wheregithub.ref_nameis<n>/merge: "Update release with assets" fails with "GitHub Releases requires a tag" (certego/django-fernet 0.1.1). pypanoptikon already patches its subtree copy.How
tag_nameand build the asset globs fromgithub.event.pull_request.title, the version already checked by "Check Tag"..claude/plans/fix-release-assets-tag/plan.md.Out of scope
softprops/action-gh-release@v2).🤖 Generated with Claude Code