Repository navigation
docs(agents): link EIP-3009 on first use in x402 and MPP - #2398
Conversation
palango
left a comment
There was a problem hiding this comment.
The EIP-3009 links look right. Both sit on the first prose mention (in mpp the earlier one is inside the mermaid diagram, where a link can't go), and the target resolves. I merged this with #2396 and #2397 locally and got no conflicts; after all three the link is still on the first mention in x402.
One thing in the description doesn't hold. It says EVM doesn't appear on these pages, but x402.mdx:15 has "Supports 170+ EVM chains", and mpp.mdx has "connect an EVM wallet" at line 49 and "a one-time EVM charge" at line 67. EVM is on the AGENTS.md list and in #2263's jargon item. Could you link it on first use in both files (https://ethereum.org/developers/docs/evm/ works) or swap in plain words, here or in a follow-up? If it's a follow-up, please fix the description so it doesn't say the check came up empty.
Optional: EIP-3009 now lives at https://ercs.ethereum.org/ERCS/erc-3009. The current URL still works, so I'm fine leaving it.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cf1992c to
a6e0a7c
Compare
|
Added EVM links on first use in x402 and mpp, and corrected the description so it no longer says EVM is absent. Kept the current EIP-3009 URL. |
palango
left a comment
There was a problem hiding this comment.
Thanks for adding the EVM links and fixing the description. Both EVM links and both EIP-3009 links sit on the first prose mention in each file, all four targets resolve, and the text around EIP-3009 matches the standard. I merged this with #2396 and #2397 again on the current heads and got no conflicts, and after all three the links in x402 are still on the first mention. Approving.
Part of #2263 (third PR, the jargon pass).
AGENTS.md section 4 asks for jargon to be linked on first use on introductory pages. I checked
overview,x402andmppfor ERC-20, EVM, EOA, facilitator, base units and EIP-3009.Changes
x402andmpp(the earlier mention inmppis inside the mermaid diagram, where a link can't go).x402("170+ EVM chains") andmpp("connect an EVM wallet").Not changed
build/agents/overviewand in the fee-abstraction guide; I did not add duplicates.Verification
npx mint broken-links: no broken links found.🤖 Generated with Claude Code