Skip to content

docs(metamask): point end users at the add-network button and the wallets page - #2355

Merged
GigaHierz merged 4 commits into
mainfrom
palango/metamask-end-user-links
Oct 7, 2026
Merged

GigaHierz merged 4 commits into
mainfrom
palango/metamask-end-user-links

Conversation

@palango

@palango palango commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

The MetaMask overview sent end users to /build/tools/wallets/metamask/setup, the developer page for calling wallet_addEthereumChain from an app, and its closing note linked the same page while promising a list of Celo native wallets. This sends end users to the add-network buttons on /learn/network/overview and to the manual Celo Sepolia guide, and points the note at the native wallets section of /learn/wallets. learn/wallets.mdx already links those two pages the same way. The developer link to the setup page stays.

Since the PR edits the page anyway, it also applies the AGENTS.md section 3 rules. Headings are sentence case without bold, the first paragraph says who the page is for, the intro comes before the <Danger> block, the description says what the reader can do, and the page ends with a ## Related list. No page links to an anchor on this one, so no other files changed.

It also deletes the bullet "See these guides if you accidentally sent ETH to CELO addresses or CELO to ETH addresses", which linked nothing, drops "we're excited to bring its functionality to the Celo ecosystem", and rewrites the Donut hard fork sentence so it no longer says "now supports" and gives the month rather than the day. It closes an unclosed parenthesis in the Valora example and fixes the garbled Ledger bullet label.

mint broken-links --check-redirects: success no broken links found.
scripts/check-orphans.sh: No orphan pages found.

@palango
palango requested a review from a team as a code owner October 2, 2026 09:11
@palango
palango requested a review from GigaHierz October 2, 2026 09:11

@GigaHierz GigaHierz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head 98f9234 · fetch matched headRefOid (no STALE); branch 7 commits behind main, merge-tree clean, reviewed on a merge of head into current main; mint broken-links --check-redirects pass, check-orphans.sh pass, CI green (broken-links, GitGuardian, StepSecurity); mint dev: 0 console errors on /tooling/wallets/metamask/use, /build-on-celo/network-overview, /home/wallets at 1440x900 and 412x915, both add-network buttons render on network-overview (372x134 at 412 wide, no horizontal scroll)

Verdict: REQUEST-CHANGES

Scope: one file, tooling/wallets/metamask/use.mdx, 2 lines changed (an end-user bullet and the closing Note link). The PR does not touch network-overview, the button snippet or docs.json.

Findings

  1. LOW-MEDIUM · tooling/wallets/metamask/use.mdx:18 · The bullet "Add Celo Mainnet or Celo Sepolia to MetaMask" promises an action but links to a developer reference page, with the button below the fold, while the real end-user walkthrough is not linked.

    • Scenario: an end user clicks it and lands on "Network Information", a chain-parameter table page whose first screen is the mainnet table and a "Replace Alfajores" Sepolia blurb. The mainnet button sits about 966px down at 1440x900 and about 1164px down at 412x915. The page has no MetaMask instructions and no mention of what the button does. The existing step-by-step page /tooling/wallets/metamask/add-celo-testnet-to-metamask (in nav under the same MetaMask group) is not linked, and main's home/wallets already links it.
    • Fix shape: keep the network-overview link but make the label match what it is, e.g. "Add Celo Mainnet to MetaMask with one click (network information)". Add [Add Celo Sepolia manually](/tooling/wallets/metamask/add-celo-testnet-to-metamask) as the testnet end-user path. Do not restate chain parameters here (one fact, one page).
  2. LOW · tooling/wallets/metamask/use.mdx:47 · The link text "here" on the edited line carries no information for readers or agents.

    • Scenario: an agent traversing links sees [here](/home/wallets) and cannot tell it is the list of Celo native wallets.
    • Fix shape: [the native wallets on Wallets for users](/home/wallets#celo-native-wallets) (anchor exists on main: "## Celo native wallets").
  3. LOW · tooling/wallets/metamask/use.mdx:14,22,26,30,38,42 (page edited by this PR) · AGENTS.md section 3 says headings on pages you are already editing get fixed. The page still has bold, Title Case headings ("How to use MetaMask with Celo", "Things to Keep in Mind", "Private Key Import", "Gas Fees Require CELO", "Incorrect Logo"). It has no ## Related, no first-paragraph audience sentence, a <Danger> block before the intro, and a non-outcome description ("Overview of MetaMask and how you can get started...").

    • Scenario: the page goes through a review again and the next docs PR has to touch the same lines.
    • Fix shape: sentence-case the headings without **, add ## Related linking /tooling/wallets/metamask/setup, /home/wallets, /build-on-celo/network-overview, rewrite description as an outcome. Alternatively file an issue and link it in the PR body.
  4. LOW (PR body) · The body says #2349 and #2350 add a metamask/setup link for holders on home/wallets.mdx and that "whichever merges should use network-overview". Both PRs are merged (2026-10-02). Main's home/wallets.mdx has no metamask/setup link; its MetaMask guide bullet already links network-overview and add-celo-testnet-to-metamask. The sentence is stale and misleads the next reader.

    • Fix shape: delete that sentence from the body.

Verified good

  • Head SHA matches the API; merge with main is clean; the PR file is unchanged on main (use.mdx on main still has both old links).
  • /build-on-celo/network-overview is in docs.json navigation (line 174 on main). /home/wallets exists and is reachable. /tooling/wallets/ledger/setup and /tooling/wallets/metamask/setup are in nav. The links resolve when clicked in mint dev (hrefs checked in the rendered DOM). Neither new link uses an anchor, so no anchor to break.
  • Claim "metamask/setup is the developer page": true. It is "Programmatic Setup", titled "How app developers can use MetaMask", and shows wallet_addEthereumChain snippets. The developer bullet to it is kept.
  • Claim "add-network buttons for Mainnet and Sepolia live on network-overview": true. <AddNetworkButton network="mainnet" /> and network="sepolia" at lines 25 and 42, imported at line 6. Props match the component's NETWORKS keys. Rendered labels "Add Celo Mainnet to your wallet" (Chain ID 42220) and "Add Celo Sepolia to your wallet" (Chain ID 11142220). Clicking with no wallet shows "No browser wallet detected. Install MetaMask, then try again." and the console stays clean.
  • Claim "the closing note promised a list of Celo native wallets": true. /home/wallets has a "Celo native wallets" section (MiniPay, Valora, Celo Terminal); the old target was the developer page.
  • Added text has no promotional words, no rocket emoji, no Alfajores, no blockquote callouts. The Note stays a <Note>.
  • mint broken-links --check-redirects and scripts/check-orphans.sh pass on the merged result. (Anchors are not checked by broken-links; the PR adds none.)

What the PR got right

  • It correctly spots that an end-user list pointed at a developer page, and that the Note promised a wallet list the target did not have. Both are real misdirections, and the fix is minimal and correctly scoped to one file.
  • It reuses the existing single-source button instead of restating chain parameters, which respects one fact one page.
  • It leaves the developer bullet in place and says so in the body.

Remaining work is one round of small text fixes (findings 1 and 2, plus 3 or a filed issue and 4), not a rethink.

Merge-order hazards

gh pr list over open PRs: none touch tooling/wallets/metamask/use.mdx, home/wallets.mdx or build-on-celo/network-overview.mdx. #2364 and #2346 touch docs.json but this PR does not, so no conflict. No stack or signature hazards.

Screenshots: /tmp/reviews/shots/2355-{use,netover,wallets}-{desktop,mobile}.png and 2355-netover-fold.png.

@palango
palango force-pushed the palango/metamask-end-user-links branch from 98f9234 to 920d8a3 Compare October 2, 2026 12:32
@palango

palango commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

All four are in 920d8a3, rebased onto current main.

  1. The end-user bullet now reads "Add Celo Mainnet or Celo Sepolia to MetaMask with one click" and keeps the network information link. Network overview has a Sepolia button as well as the Mainnet one, so the bullet names both. A second bullet, "Add Celo Sepolia manually", links add-celo-testnet-to-metamask. No chain parameters on this page.
  2. The note now links "the native wallets on Wallets for users" at /home/wallets#celo-native-wallets.
  3. Done in this PR rather than a separate issue. Headings are sentence case without bold, the colons are gone from the two H3s, an audience sentence comes first, the Danger block follows the intro, the description is an outcome, and the page closes with a Related section. Nothing in the repo links to anchors on this page.
  4. Removed the stale sentence about docs(wallets): add end-user troubleshooting for common unanswered assistant questions #2349 and docs(wallets): split the wallet docs into an end-user page and a developer integration page #2350 from the body.

mint broken-links and scripts/check-orphans.sh pass.

@palango
palango requested a review from GigaHierz October 2, 2026 12:32
@palango

palango commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

One more commit, 8a75393, for wording on the same page that the review did not flag. It removes "we're excited to bring its functionality to the Celo ecosystem" and rewrites the Donut hard fork sentence so it no longer says "now supports". It also deletes "See these guides if you accidentally sent ETH to CELO addresses", which pointed to guides that do not exist. mint broken-links and scripts/check-orphans.sh pass.

@GigaHierz GigaHierz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head 8a75393 · fetch matched headRefOid (API == refs/remotes/pr/2355); branch 4 commits behind main (main already has the learn/ move, #2367; no build/ move yet), merge-tree clean, checks run on a merge of head into main a12466b: mint broken-links --check-redirects pass, check-orphans.sh pass, CI green (broken-links, GitGuardian, StepSecurity); mint dev on :3411: 0 console errors on /tooling/wallets/metamask/use at 1280 and 412x915, no horizontal scroll

Verdict: REQUEST-CHANGES

Scope: one file, tooling/wallets/metamask/use.mdx (+24/-16 across three commits, rebased on 92b8cc6, which is 4 commits before current main).

Status of earlier findings

  1. Bullet promised an action but linked a reference page, with no end-user walkthrough: FIXED. use.mdx:20 now reads "Add Celo Mainnet or Celo Sepolia to MetaMask with one click (network information)" and use.mdx:21 adds "Add Celo Sepolia manually". That page exists, is in nav, and uses Celo Sepolia (chain 11142220, https://forno.celo-sepolia.celo-testnet.org). No chain parameters are restated here. (The target path of line 20 is stale, see new finding 1.)
  2. "here" link text: FIXED. use.mdx:49 now reads "the native wallets on Wallets for users". The anchor exists (## Celo native wallets, learn/wallets.mdx:20) and survives the redirect (checked in mint dev: /home/wallets#celo-native-wallets lands on /learn/wallets#celo-native-wallets). Path stale, see new finding 1.
  3. Headings, Related, audience sentence, Danger order, description: FIXED. Headings are sentence case without bold (use.mdx:16-47); audience sentence at line 6; intro precedes <Danger> (lines 6-14); ## Related at line 52 with three internal links; description at line 3 is an outcome with no trailing period. Rendered H1/H2/H3 list confirmed in mint dev.
  4. Stale sentence about #2349/#2350 in the body: FIXED (sentence is gone from the body). The body still carries a different stale claim, see new finding 2.

New findings

  1. LOW-MEDIUM · tooling/wallets/metamask/use.mdx:20, 49, 55, 56 · The PR adds four links to paths that were moved by #2367: /build-on-celo/network-overview (now a redirect to /learn/network/overview) and /home/wallets (now a redirect to /learn/wallets). AGENTS.md section 2 says to point at the final page, not at another redirect.
    • Scenario: after merging into main, grep -rn "/home/\|build-on-celo/network-overview" --include='*.mdx' finds exactly these four lines and nothing else in the repo, because #2367 rewrote every other inbound link (learn/wallets.mdx:93 already links /learn/network/overview). The links work today through the redirects (verified by clicking them in mint dev), but the next page move that prunes or retargets those redirects breaks them, and mint broken-links will not warn until then.
    • Fix shape: rebase onto main and replace with /learn/network/overview (lines 20, 56), /learn/wallets#celo-native-wallets (line 49), /learn/wallets (line 55).
  2. LOW (PR body) · The body still says the note points at "the native wallets section of /home/wallets" and that "home/wallets.mdx already links those two pages the same way". home/wallets.mdx no longer exists on main (it is learn/wallets.mdx). The body also does not mention the removed bullet ("See these guides if you accidentally sent ETH to CELO addresses...", which had no link) or the wording edits in 8a75393; they are only in a PR comment.
    • Scenario: a reader of the squash commit looks for home/wallets.mdx and cannot find it, and does not learn that a bullet was deleted.
    • Fix shape: update the body paths to learn/wallets and add one sentence listing the deleted bullet and the dropped promotional/dated wording.
  3. LOW · tooling/wallets/metamask/use.mdx:37 and :22 · Two text defects on the page the PR is already rewriting. Line 37 opens a parenthesis "(e.g. Valora you'd have to import..." and never closes it. Line 22 reads "Setup a Ledger to Work with MetaMask to Work With Celo" (duplicate "to Work", Title Case, "Setup" as a verb) while its two siblings were just sentence-cased.
    • Scenario: the line renders with a dangling parenthesis, and an agent reading the Ledger bullet gets a garbled label.
    • Fix shape: line 37 add ) after "Valora"'s link; line 22 "Set up a Ledger to use with MetaMask on Celo".

Verified good

  • Chain facts: eth_chainId on https://forno.celo.org returns 0xa4ec (42220) and on https://forno.celo-sepolia.celo-testnet.org returns 0xaa044c (11142220); both match the AddNetworkButton snippet that the new bullet relies on and the manual page's parameters.
  • "Donut hard fork in May 2021": CIP-27 lists mainnet block 6774000 on May 19th, 2021, status Final. "Ethereum-compatible transactions": CIP-35 "Support for Ethereum-compatible transactions", status Final, and its abstract says these transactions omit the feecurrency field, which supports "Gas fees require CELO".
  • Claim that metamask/setup is the developer page: true, and the developer bullet at line 28 is kept.
  • Claim that network overview carries Mainnet and Sepolia buttons: true at the new location, learn/network/overview.mdx:25 and :42.
  • Removed bullet had no link target at all; removing it is correct. Removed "we're excited..." is promotional wording, correctly dropped.
  • No rocket emoji, no Alfajores, no > callouts, <Danger>/<Note> components kept. Frontmatter has title and description only.
  • Rendered page at 1280 and 412x915: headings as expected, hrefs as listed above, 0 console errors, scrollWidth equals clientWidth at 412.

What the PR got right

  • Correctly found that an end-user list pointed at a developer page and that the closing note promised a wallet list the target did not have, and fixed both minimally.
  • Reuses the single-source add-network button instead of restating chain parameters.
  • Took the section 3 clean-up on the same page rather than leaving it for a second PR, and answered each earlier finding with a commit.

Remaining work is one small rebase-and-retarget (finding 1) plus a body edit and two text fixes, not a rethink.

Merge-order hazards

  • Against #2368 (head 961edef, moves tooling/ and build-on-celo/ into build/): git merge-tree of this PR with that head conflicts in build/tools/wallets/metamask/use.mdx (content conflict; rename detected, link rewrites overlap). Whoever merges second has to redo this file: if #2368 goes first, this PR must be rebased and its edits re-applied at build/tools/wallets/metamask/use.mdx, with finding 1 links written against /learn/... and any /build/... paths.
  • Behind main: 4 commits, merge-tree against main is clean.

@palango
palango enabled auto-merge (squash) October 6, 2026 12:30
@palango
palango force-pushed the palango/metamask-end-user-links branch from 8a75393 to c33403e Compare October 6, 2026 12:32
@palango

palango commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

All three are in c33403e, rebased onto current main.

  1. The four links now point at the final pages: /learn/network/overview (twice), /learn/wallets#celo-native-wallets and /learn/wallets. The file has no /home/ or build-on-celo/network-overview paths left. I left the /tooling/... links alone since docs: merge Build on Celo and Tooling into one Build tab #2368 moves those.
  2. The body now uses the learn/ paths and lists the deleted bullet, the dropped promotional and dated wording, and the two text fixes.
  3. The Valora parenthesis is closed, and the Ledger bullet reads "Set up a Ledger to use with MetaMask on Celo".

@GigaHierz GigaHierz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head c33403e · API headRefOid == refs/remotes/pr/2355 after force re-fetch; 4 commits on a12466b, 1 file (+26/-18); git merge-tree --write-tree --name-only origin/main (7b8f97c, #2368) CONFLICTS in build/tools/wallets/metamask/use.mdx (rename detected, content conflict, 3 hunks); on a trial merge with that file resolved by hand (instructions below): mint broken-links --check-redirects no broken links, scripts/check-orphans.sh no orphan pages; gh pr checks: broken-links, GitGuardian, StepSecurity pass, Mintlify Deployment skipping; forno eth_chainId returns 0xa4ec and 0xaa044c

Verdict: REQUEST-CHANGES

Status of earlier findings

Earlier review was at 8a75393 (newest of two).

  1. Four links to paths moved by #2367 (/build-on-celo/network-overview, /home/wallets x3): FIXED. use.mdx now links /learn/network/overview (lines 20 and 56), /learn/wallets#celo-native-wallets (line 49) and /learn/wallets (line 55). The file contains no /home/ or /build-on-celo/network-overview path. (It still contains /tooling/... links and one /build-on-celo/fee-abstraction/overview link, which #2368 has since moved; see finding 1.)
  2. PR body stale (home/wallets.mdx, deleted bullet not mentioned): FIXED. The body now says /learn/wallets, lists the deleted bullet, the dropped promotional and dated wording and the two text fixes. Its claim that learn/wallets.mdx "already links those two pages the same way" holds: learn/wallets.mdx:93 links /learn/network/overview and the Celo Sepolia add-to-MetaMask page.
  3. Unclosed parenthesis and garbled Ledger label: FIXED. The Valora example reads "(e.g. Valora), you'd have to import..." and the bullet reads "[Set up a Ledger to use with MetaMask on Celo]".
  4. Earlier-round items (end-user bullet, "here" link text, headings, Related, audience sentence, Danger order, description): still FIXED, no change.

Findings

  1. MEDIUM (layout, author must rebase) · tooling/wallets/metamask/use.mdx (now build/tools/wallets/metamask/use.mdx) · #2368 renamed the file and rewrote its internal links in the same regions this PR rewrites, so the branch cannot merge as it stands.
    • Scenario: "Update branch" or a squash merge stops on a content conflict in three hunks (the end-user bullet list, the private-key bullets, and the closing <Note>). Taking main's side silently drops every change in this PR; taking the PR's side reverts main's link rewrites and re-introduces /tooling/wallets/... and /build-on-celo/fee-abstraction/overview links that only work through redirects.
    • Fix shape: rebase onto current main, take the PR's version of the file at build/tools/wallets/metamask/use.mdx, and rewrite the old-layout links in it. The exact set, which I applied in a trial merge and then ran the link and orphan checks on:
      • /tooling/wallets/metamask/add-celo-testnet-to-metamask -> /build/tools/wallets/metamask/add-celo-testnet-to-metamask (line 21)
      • /tooling/wallets/ledger/setup -> /build/tools/wallets/ledger/setup (line 22)
      • /tooling/wallets/metamask/setup -> /build/tools/wallets/metamask/setup (lines 26 and 54)
      • /tooling/wallets/metamask/import -> /build/tools/wallets/metamask/import (line 38)
      • /build-on-celo/fee-abstraction/overview -> /build/fee-abstraction/overview (line 42, an untouched line in this PR that main did edit)
      • Leave /learn/network/overview (lines 20, 56), /learn/wallets#celo-native-wallets (line 49) and /learn/wallets (line 55) as they are.
    • The earlier PR comment's remark that the /tooling/... links are left alone because #2368 moves them is now moot; no body change is needed beyond that.

No content findings.

Verified good

  • Chain IDs: eth_chainId on https://forno.celo.org returns 0xa4ec (42220) and on https://forno.celo-sepolia.celo-testnet.org returns 0xaa044c (11142220). Both match the AddNetworkButton snippet params and the manual Celo Sepolia page (RPC https://forno.celo-sepolia.celo-testnet.org, chain ID 11142220).
  • CIP statements: CIP-27 "Donut Hardfork", status Final, mainnet block 6774000 on May 19th 2021, and its specification list includes CIP-35. CIP-35 "Support for Ethereum-compatible transactions", status Final; its abstract says these transactions omit the feecurrency field, which supports "Gas fees require CELO". "In May 2021" is correct.
  • AddNetworkButton bullet: learn/network/overview.mdx renders both buttons ("Add Celo Mainnet to your wallet, Chain ID 42220" and "Add Celo Sepolia to your wallet, Chain ID 11142220"), and the snippet calls wallet_addEthereumChain, preferring the MetaMask provider when several are injected. "Add ... to MetaMask with one click" is accurate.
  • Anchor #celo-native-wallets exists (## Celo native wallets, learn/wallets.mdx:20). Link targets exist and are in nav: add-celo-testnet-to-metamask, ledger/setup, metamask/setup, metamask/import. /learn/wallets title "Wallets for users" matches the link text.
  • AGENTS.md rules on the page: frontmatter has title and description only; description is an outcome with no trailing period; first paragraph names the audience; no H1; sentence-case headings, no bold, no emoji, no questions; callouts are <Danger>/<Note>; ## Related closes the page with internal links, a dash and a half-sentence each; no promotional wording; no Alfajores.
  • Smoke render of the hand-resolved trial merge: page returns 200, headings as listed above, all internal hrefs as listed above (new layout), no horizontal scroll at 1280 or 412 wide, no console errors. Smoke test only.
  • Not verified, unchanged by the PR: the sentence "MetaMask does not natively support Celo compatibility and some features won't work perfectly" (intro of "Things to keep in mind" and closing <Note>). It is consistent with learn/wallets.mdx:181 ("MetaMask does not show Celo until the network is added").

What the PR got right

Sending end users to the single-source add-network buttons instead of restating chain parameters, answering every earlier finding with a commit and updating the body to match, and taking the AGENTS.md page-anatomy clean-up on the same page rather than leaving it for a second PR.

Merge-order hazards

  • #2368 is on main; this is the only one of the three PRs that conflicts with it. Pairwise git merge-tree with #2346 and #2357: clean, so there is no ordering constraint among the three.
  • Rebase work, in order: git rebase origin/main; on the conflict in build/tools/wallets/metamask/use.mdx take the PR's file and apply the link rewrites listed in finding 1; run mint broken-links --check-redirects and bash scripts/check-orphans.sh; force-push.

Link the Sepolia manual guide, give the wallets link a descriptive label,
sentence-case the headings, add an audience line and Related section.
The network overview and wallets pages moved under learn/, so link the
final paths instead of redirects. Close the Valora parenthesis and
sentence-case the Ledger bullet.
@palango
palango force-pushed the palango/metamask-end-user-links branch from c33403e to 392a835 Compare October 7, 2026 05:13
@palango

palango commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current main. The file is now at build/tools/wallets/metamask/use.mdx, and I resolved the conflict in each of the four commits by taking the PR's version of the file and rewriting the old-layout links in it, so the history stays as it was. The final file differs from the previous head (c33403e) only in the six links you listed: /tooling/wallets/... to /build/tools/wallets/... on lines 21, 22, 26, 38 and 54, and /build-on-celo/fee-abstraction/overview to /build/fee-abstraction/overview on line 42. The /learn/ links stay as they were. Against main, the only remaining differences are the PR's own edits; main's link rewrites are all kept. The new head is 392a835.

mint broken-links --check-redirects finds no broken links, mint validate passes and scripts/check-orphans.sh finds no orphan pages. The PR body now names /build/tools/wallets/metamask/setup as the page end users were sent to.

@palango
palango requested a review from GigaHierz October 7, 2026 05:13

@GigaHierz GigaHierz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head 392a835 · API headRefOid == refs/remotes/pr/2355 after force re-fetch; 4 commits on origin/main 7f5d9bb, 1 file (build/tools/wallets/metamask/use.mdx, +26/-18); git merge-tree --write-tree origin/main clean (no conflicts); mint broken-links --check-redirects no broken links, mint validate pass, scripts/check-orphans.sh no orphan pages; gh pr checks: broken-links, GitGuardian, StepSecurity pass, Mintlify Deployment skipping; forno eth_chainId returns 0xa4ec (42220) and 0xaa044c (11142220)

Verdict: APPROVE

Status of earlier findings

  1. MEDIUM, branch conflicted with the layout move and kept old-layout links: FIXED. The branch is rebased, the file is at build/tools/wallets/metamask/use.mdx, and the six links I listed are rewritten (/build/tools/wallets/metamask/add-celo-testnet-to-metamask line 21, /build/tools/wallets/ledger/setup line 22, /build/tools/wallets/metamask/setup lines 26 and 54, /build/tools/wallets/metamask/import line 38, /build/fee-abstraction/overview line 42). A search of the file for /tooling, /build-on-celo, /home/ and ../ finds nothing.
  2. Four links to paths moved by the learn/ restructure: FIXED, unchanged (/learn/network/overview lines 20 and 56, /learn/wallets#celo-native-wallets line 49, /learn/wallets line 55).
  3. Stale PR body: FIXED. It names /build/tools/wallets/metamask/setup and /learn/wallets, lists the deleted bullet, the dropped promotional and dated wording and the two text fixes; every claim matches the diff.
  4. Dangling parenthesis (Valora example, line 37) and garbled Ledger label (line 22): FIXED. Line 37 reads "(e.g. Valora), you'd have to import it..." and line 22 reads "Set up a Ledger to use with MetaMask on Celo".
  5. Earlier-round items (end-user bullet, link text, headings, ## Related, audience sentence, Danger order, description): still FIXED.

No new findings.

Verified good

  • Every internal link by hand: /build/tools/wallets/metamask/add-celo-testnet-to-metamask, /build/tools/wallets/ledger/setup, /build/tools/wallets/metamask/setup, /build/tools/wallets/metamask/import, /build/fee-abstraction/overview, /learn/wallets, /learn/network/overview each exist as .mdx and are listed once in docs.json navigation. Anchor #celo-native-wallets exists (## Celo native wallets, learn/wallets.mdx:20). Link text "Wallets for users" matches that page's title.
  • Chain IDs: eth_chainId on https://forno.celo.org returns 0xa4ec (42220); on https://forno.celo-sepolia.celo-testnet.org returns 0xaa044c (11142220). learn/network/overview.mdx renders AddNetworkButton for mainnet (line 25) and Sepolia (line 42), so "Add Celo Mainnet or Celo Sepolia to MetaMask with one click" is accurate.
  • AGENTS.md: frontmatter has only title and description, the description is an outcome with no trailing period; first paragraph names the audience; no H1; headings are sentence case, no bold, no emoji, no questions; callouts are <Danger> and <Note>; ## Related closes the page with a dash and a half-sentence per link; no promotional wording; no Alfajores.
  • Rendering (smoke test only, my own server on port 3712, Playwright tab opened and closed by me): page returns 200, no horizontal scroll, no console errors, headings end with "Related", the rendered hrefs are exactly the new-layout paths above, and the Valora text contains the closed parenthesis. My first mint dev served main's cached version of the page (old headings, "For end users:" with a colon); after restarting my own server the page is the PR's.
  • CIP claims from the earlier round (CIP-27 Donut hard fork, May 2021; CIP-35 Ethereum-compatible transactions omit feeCurrency) are unchanged by the rebase; the PR diff against main touches only this file.

What the PR got right

Sent end users to the single-source add-network buttons instead of restating chain parameters, resolved the layout conflict by taking the PR's file and rewriting only the old-layout links (the final file differs from the previously reviewed head only in those six links), kept history per commit, and folded the AGENTS.md page-anatomy clean-up into the same page.

Merge-order hazards

  • None. Clean against current main; the PR touches one file that no other open PR in this batch edits (#2346 changes no file in common with it). Squash-merge in any order.

@GigaHierz
GigaHierz merged commit 909f824 into main Oct 7, 2026
5 checks passed
@GigaHierz
GigaHierz deleted the palango/metamask-end-user-links branch October 7, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants