Repository navigation
fix: make AGP 9.5 generated projects assemble on JDK 17 - #516
Merged
Merged
Conversation
AGP 9.5 cannot store the configuration cache when Gradle runs on an older JVM than the generated Android target compatibility. Point Lint at the project toolchain so JDK 17 can still assemble JDK 21 projects.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetCompatibility.android.lint.toolchain.languageVersionto the project JDK on AGP 9.5+, which is the workaround AGP documents for this mismatch.Supersedes #515.
Test plan
CompositeBuildPluginAndroidLintToolchainTest(emits toolchain on 9.5, not on 9.4):project-generator:unitTestAgp9NewDslDiVariantsE2EValidationTeston JDK 17 (assembleDebug --configuration-cachefor HILT and NONE)Agp9NewDslDiVariantsE2EValidationTest/ JDK 17