Repository navigation
Conversation
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--preflightto the kapp flags that an App'sspec.deploy[].kapp.rawOptionsmay set fordeploy, so the kapp preflight checks (for example--preflight=PermissionValidation=true) can be enabled from the App CR. The bundled kapp (v0.65.4) already supports the flag; kapp-controller only rejected it as an unknown flag.The flag is allowed for
deployonly, because kapp registers it only on that command.deleteandinspectstill reject it.Test:
TestPreflightFlagAllowedOnlyForDeployinpkg/deploy. I rango test ./pkg/deploy ./pkg/exec; I did not run the e2e tests against a cluster.Refs #1381 (as suggested in the discussion there, enabling the permission check from the App spec; the issue also asks about a dedicated App field, which this does not add).