Repository navigation
Keep sensitive configuration and child output out of diagnostics - #1875
Open
sameerforge wants to merge 1 commit into
Open
sameerforge wants to merge 1 commit into
sameerforge wants to merge 1 commit into
Conversation
Redact URL queries, fragments and error fields before status presentation. Keep original rendered manifests separate from diagnostic copies. Suppress opaque ytt diagnostics for Secret-backed values, while retaining corrective guidance. Replace kctrl configuration dumps with identity summaries and stop teeing raw child output into debug logs. Add focused regression tests. Signed-off-by: Sameer Khan <sameer.khan@broadcom.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sanitize URL queries/fragments and error fields before presenting command results. Keep the original rendered manifest separate from its diagnostic copy. Omit opaque ytt diagnostics when Secret-backed values are supplied and provide corrective guidance. In kctrl, display resource identities instead of complete App/PackageInstall objects, omit vendir configuration-file printing and stop teeing raw child output into debug logs.
Validation
go test ./pkg/exec ./pkg/template ./pkg/app ./pkg/pkgrepositorywith the baseline ytt/vendir tools on PATH.cd cli && go test ./pkg/....golangci-lint runpasses.golangci-lint runreports 25 existing findings, reproduced on unchangeddevelop;golangci-lint run --new-from-rev upstream/developpasses.go test ./pkg/...has two existing failures inpkg/configandpkg/fetch, also reproduced on unchangeddevelop.Does this PR introduce a user-facing change?