Skip to content

Bump lombok, slf4j and the compiler/source plugins - #204

Merged
edridudi merged 1 commit into
mainfrom
claude/dependabot-batch
Sep 12, 2026
Merged

edridudi merged 1 commit into
mainfrom
claude/dependabot-batch

Conversation

@edridudi

Copy link
Copy Markdown
Collaborator

Batches four dependabot proposals that build and test cleanly together, rebased onto current main.

Dependency Before After Supersedes
lombok 1.18.36 1.18.48 #202
slf4j-reload4j 2.0.16 2.0.19 #200
slf4j-api 2.0.16 2.0.19 —
maven-compiler-plugin 3.13.0 3.16.0 #199
maven-source-plugin 3.3.1 3.4.0 #198

slf4j-api is included because #200 bumped only the reload4j binding, leaving the api behind. They are meant to move in step.

Not included: #201 (retrofit 3.0.0)

retrofit.version drives both retrofit and converter-jackson, so #201 is a major bump of the whole HTTP layer, not just the converter its title names. It needs its own change and its own testing.

About lombok and JDK 25

Worth recording, since it comes up whenever anyone builds locally: 1.18.48 does not fix JDK 25. Compiling there still fails with 96 cannot find symbol errors — the annotation processor silently does not run, so no generated getters exist:

[ERROR] .../BaseService.java:[135,46] cannot find symbol

JDK 21 remains the supported local build. CI is unaffected (it uses JDK 11).

Testing

mvn test -Dtest='*Preview*,ProposalDeserializationTest,*Bech32*'   # 130/130 pass

Same command the Codecov workflow runs, on JDK 21.

🤖 Generated with Claude Code

Batches four dependabot proposals that build and test cleanly together:

  lombok                1.18.36 -> 1.18.48   (#202)
  slf4j-reload4j        2.0.16  -> 2.0.19    (#200)
  maven-compiler-plugin 3.13.0  -> 3.16.0    (#199)
  maven-source-plugin   3.3.1   -> 3.4.0     (#198)

slf4j-api moves to 2.0.19 as well, which #200 left behind — the api and
the reload4j binding are meant to stay in step.

Note that lombok 1.18.48 still does not support JDK 25: compiling there
fails with the annotation processor silently not running. JDK 21 remains
the supported local build.

Retrofit 3.0.0 (#201) is deliberately not included - retrofit.version
drives both retrofit and converter-jackson, so it is a major bump of the
HTTP layer and wants its own change.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant