Repository navigation
Make the time display, visualizer and doublesize button keyboard operable - #1373
Open
captbaritone wants to merge 2 commits into
Open
captbaritone wants to merge 2 commits into
captbaritone wants to merge 2 commits into
Conversation
|
Size Change: +153 B (+0.03%) Total Size: 491 kB 📦 View Changed
|
captbaritone
force-pushed
the
a11y-main-window-controls
branch
from
October 12, 2026 19:29
68708c0 to
c6b3feb
Compare
captbaritone
force-pushed
the
a11y-main-window-controls
branch
3 times, most recently
from
October 15, 2026 16:59
4c4a975 to
d773822
Compare
✅ Deploy Preview for tourmaline-kringle-c98715 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…able - Time display (toggles elapsed/remaining): render as a WinampButton named "Toggle Remaining Time" with aria-pressed. - Visualizer canvas (cycles visualizer style): role="button", tabIndex=0, named "Change Visualizer Style", activated with Enter/Space. - Clutter bar D (doublesize): role="button", tabIndex=0, aria-pressed, and Enter/Space handling. It toggles on pointerup rather than click, so it can't rely on WinampButton's click-based activation. Extract WinampButton's Enter/Space handling into an exported handleActivationKey helper so the canvas and clutter bar button can share it.
captbaritone
force-pushed
the
a11y-main-window-controls
branch
from
October 15, 2026 17:19
d773822 to
58f2494
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1365 (merged), which makes
WinampButtons with anonClickinto focusablerole="button"elements.Three more main-window actions were mouse-only:
#time)WinampButtonnamed "Toggle Remaining Time", witharia-pressed<canvas id="visualizer">)role="button",tabIndex={0}, named "Change Visualizer Style", Enter/Space activates#button-d)role="button",tabIndex={0},aria-pressed, Enter/Space activates (keeps its existingtitle)WinampButtonbecause it's a<canvas>.pointerup, notclick, so anonClickwould make a mouse click toggle twice.handleActivationKey(e, activate)helper. It's Make Webamp's buttons keyboard and screen reader operable #1365's Enter/Space logic pulled out ofWinampButton, which now uses it too.winamp-activeon#time.Testing
mainWindowControls.test.tsx:aria-pressed.aria-pressedand.selectedupdate.WinampButtontests already cover.tsc,eslint,prettier --checkandvitest run(218 passed) pass locally.