Repository navigation
Make the equalizer's +12/0/-12 dB buttons keyboard operable - #1372
Open
captbaritone wants to merge 1 commit into
Open
captbaritone wants to merge 1 commit into
captbaritone wants to merge 1 commit into
Conversation
|
Size Change: +80 B (+0.02%) Total Size: 490 kB 📦 View Changed
|
These were plain divs with onClick, so they were mouse-only and unnamed. Render them as WinampButtons (which become focusable role="button" elements when they have an onClick) with accessible names.
captbaritone
force-pushed
the
a11y-eq-db-buttons
branch
from
October 12, 2026 19:29
eeb5a96 to
e4af708
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1365 (merged), which makes
WinampButtons with anonClickinto focusablerole="button"elements.The equalizer's "+12db", "+0db" and "-12db" labels are part of the background sprite. Clicking one sets every band to that level, through transparent
divs with anonClick. Thosedivs weren't focusable, had no role, and had no name.This renders them as
WinampButtons named "Set all bands to +12 dB", "Set all bands to 0 dB" and "Set all bands to -12 dB".divs with the same ids. While pressed,WinampButtonadds awinamp-activeclass, but no skin CSS targets it for these ids.Testing
tsc,eslint,prettier --checkandvitest runpass locally.