Repository navigation
fix!: return parsed job logs and remove git_repository_url - #5
Merged
Merged
Conversation
- `jobs.logs()` returns a list of `JobLog` instead of the raw JSON response text - remove `git_repository_url` from `apps.update()`, which the API ignores; use `apps.repository.set()` instead BREAKING CHANGE: `jobs.logs()` returns `List[JobLog]` instead of `str`, and `apps.update()` no longer accepts `git_repository_url`.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the documented API behavior and includes appropriate model exports, tests, and usage updates.
Review effort: Balanced
Findings: None
What changed in this PR
Updates job log handling to return typed models and removes an obsolete app update parameter.
Changes:
- Parses job logs into
JobLogobjects. - Removes
git_repository_urlfrom app updates. - Updates tests, README, and native build example.
| File | Description |
|---|---|
tests/test_jobs.py |
Tests parsed job logs. |
src/capawesome_cloud/resources/jobs.py |
Returns typed log entries. |
src/capawesome_cloud/resources/apps.py |
Removes obsolete repository URL parameter. |
src/capawesome_cloud/models.py |
Defines JobLog. |
src/capawesome_cloud/__init__.py |
Exports JobLog. |
README.md |
Documents iterating over logs. |
examples/trigger_native_build.py |
Prints individual log payloads. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two existing bugs found while syncing with the Node SDK (#2).
jobs.logs()returned the raw JSON response text, although the API returns a list of log lines. It now returnsList[JobLog](number,payload,timestamp), matching the Node SDK'sgetLogs().apps.update(git_repository_url=...)had no effect because the API no longer acceptsgitRepositoryUrl. The parameter is removed; useapps.repository.set()to link a repository.The README and the native build example are updated accordingly.
Breaking change:
jobs.logs()returnsList[JobLog]instead ofstr, andapps.update()no longer acceptsgit_repository_url.