Repository navigation
feat(automations): support multiple channels - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation consistently maps, parses, documents, and tests the new channel behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds multi-channel automation support while retaining deprecated singular channel fields.
Changes:
- Maps channel ID/name lists in create and update requests.
- Exposes response channel IDs.
- Tests creation, parsing, and clearing channels.
| File | Description |
|---|---|
tests/test_resources.py |
Tests multi-channel request and response behavior. |
src/capawesome_cloud/resources/automations.py |
Adds plural channel fields and documentation. |
src/capawesome_cloud/models.py |
Exposes automation channel IDs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds multi-channel support to automations, introduced by capawesome-team/cloud-api-worker#874.
automations.create()/update()acceptapp_channel_idsandapp_channel_names, sent asappChannelIds/appChannelNames. Previously these kwargs raisedTypeError.app_channel_id/app_channel_namestill work but are documented as deprecated, same wording asbuilds.create().update(app_channel_ids=[])removes all channels; omitted fields stay unchanged.AppAutomation.app_channel_idsexposes the channels from the response.Depends on capawesome-team/cloud-api-worker#874. Release after the API PR is deployed.