Repository navigation
fix(apps): skip symbolic links outside the source folder when zipping sources - #258
Merged
Merged
Conversation
… sources Symbolic links that point outside the project folder are no longer included in build source archives, matching live update bundles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The containment check mishandles filesystem roots, and excluded files still count toward the ZIP-entry limit.
2 open issues
What changed in this PR
This PR updates build-source archiving to exclude symbolic links whose targets are outside the project folder, matching live update bundle behavior.
Changes:
- Adds resolved-path checks before including files in source archives.
- Adds a regression test covering external file and directory links.
| File | Description |
|---|---|
src/utils/zip.ts |
Filters files whose resolved paths fall outside the source folder. |
src/utils/zip.test.ts |
Tests exclusion of external symbolic links while retaining a project file. |
Review effort: Balanced
Comment on lines
+78
to
+80
| if (isOutsideFolder(filePath, realSourceFolder)) { | ||
| continue; | ||
| } |
| // so that `addLocalFile` reports it as a vanished file. | ||
| const isOutsideFolder = (filePath: string, realFolder: string): boolean => { | ||
| try { | ||
| return !fs.realpathSync(filePath).startsWith(realFolder + path.sep); |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbolic links that point outside the project folder are no longer included in build source archives, matching live update bundles.
Links that stay inside the folder still work.
Added a unit test with a file link and a folder link that point outside the source folder.
🤖 Generated with Claude Code