Skip to content

Replace CA bundle with certifi - #99

Merged
AlexisT-CM merged 8 commits into
campaignmonitor:masterfrom
merfolk:replace-ca-bundle-with-certifi
Oct 30, 2026
Merged

AlexisT-CM merged 8 commits into
campaignmonitor:masterfrom
merfolk:replace-ca-bundle-with-certifi

Conversation

@merfolk

@merfolk merfolk commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

What?

Replace the CA bundle with certifi.

Why?

The certifilibrary is easier to keep up to date. For example, it's easy to add a Dependabot configuration for Python/pip requirements.

This will lead to more secure connections for consumers of the createsend-python package.

@merfolk

merfolk commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Relates to #98

@AlexisT-CM

Copy link
Copy Markdown
Contributor

@merfolk

One change before we merge this one: could you loosen the pin in requirements.txt to certifi>=2024.2.2? With ==, consumers can't pick up newer CA data without a new createsend release, and they'd hit resolver conflicts with other packages that depend on certifi. It'll also need a rebase now that #98 is merged. Once it's updated we'll release it as 9.2.0.

@merfolk
merfolk force-pushed the replace-ca-bundle-with-certifi branch from 560435a to c15149d Compare October 28, 2026 08:12
@merfolk

merfolk commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@AlexisT-CM good point! I loosened the requirement as you suggested and rebased the branch. 🙂

Fair warning, though: only certifi>=2026.10.18 drops the compromised eMudhra / emSign G3 certificates:

@AlexisT-CM

Copy link
Copy Markdown
Contributor

@merfolk

Good catch on the emSign floor. I've pushed a commit to your branch raising the requirement to certifi>=2026.10.18, so existing installs on older certifi versions get upgraded instead of staying on a bundle with the compromised roots. I'll merge this and release it as 9.2.0.

Once again thanks for raising this 😃

@AlexisT-CM
AlexisT-CM merged commit 4e90949 into campaignmonitor:master Oct 30, 2026
7 checks passed
@merfolk
merfolk deleted the replace-ca-bundle-with-certifi branch October 30, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants