Repository navigation
Highlight recognised text in NLP input; update tasknotes-nlp-core to 0.3.0 - #2438
Merged
Merged
Conversation
Update tasknotes-nlp-core to 0.3.0 (span-based parsing, fuller language data) and mark the spans it reports in the task creation dialog's natural language editor, coloured by kind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tasknotes-nlp-coreto 0.3.0 (0.3.0: span-based parsing, createTaskParser and full language data tasknotes-nlp-core#8, A couple of suggestions based on reddit info #9). The parser is now span-based, every language has fuller data, and it includes the [Bug]: Italian NLP misparses dates, times, estimates and weekdays #2433 Italian fixes reported by @starise.src/editor/NLPHighlight.ts) that highlights recognised spans by kind in the task creation dialog's NLP editor, usingparseInputWithSpans. Styles use.tn-nlp-highlight--<kind>with theme colours.fait,低,完成) no longer match, so tests use the full phrasesChecks:
e2e/nlp-highlighting.spec.ts(new) andissue-2404-nlp-enter-save