Skip to content

Fix Italian NLP date fields and accented weekdays (#2428) - #2430

Merged
callumalpass merged 2 commits into
mainfrom
fix/2428-italian-nlp
Oct 26, 2026
Merged

callumalpass merged 2 commits into
mainfrom
fix/2428-italian-nlp

Conversation

@callumalpass

@callumalpass callumalpass commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Fixes #2428. Thanks to @starise for the reproduction and root-cause analysis.

The implementation lives in tasknotes-nlp-core, not the plugin. Source fixes merged as callumalpass/tasknotes-nlp-core#6 and callumalpass/tasknotes-nlp-core#7 after green CI. Pin the final immutable merge commit c148eed995f8de0f9fa7a8bf4d7177ddb69c145a over HTTPS (prepare builds ESM/CJS on install); no npm publication, tag, version bump or plugin release.

  • Adds entro le and complete masculine/feminine scheduled triggers. Specificity-based Italian precedence protects both scheduled phrases and existing entro il/per il due phrases.
  • Unicode-aware recurrence boundaries with u preserve accented weekday endings and prevent matches inside longer Unicode words or hyphenated titles.
  • 41 new core tests: all reported rows and working controls; seven weekdays; punctuation, ordinal/plural forms; Unicode negative cases; weekday spellings across all 12 languages; due controls and mixed due/scheduled input in either order. Core suite: 89 passed.
  • 19 plugin adapter regressions using real date libraries, including all reported rows and working controls. NLP suite: 237 passed, 21 pre-existing skips.
  • Updates the existing Italian locale smoke expectation for relative-day support already present in the newer core.

Local lint, typecheck, production build, bundle-size budget, 77 integration tests and all 62 i18n-source tests pass. Local full coverage run exceeded the 120s command budget without reported failures. Hosted full plugin CI pending.

@callumalpass
callumalpass merged commit 7eba1ad into main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Italian NLP misclassifies date expressions and fails on accented weekdays

1 participant