Skip to content

Fix weekday-dependent recurring edit scope E2E fixture - #321

Merged
callumalpass merged 1 commit into
mainfrom
fix/recurring-edit-scope-e2e
Oct 30, 2026
Merged

callumalpass merged 1 commit into
mainfrom
fix/recurring-edit-scope-e2e

Conversation

@callumalpass

Copy link
Copy Markdown
Owner

Root cause

This is a date-dependent E2E fixture assumption, not a recurring-calendar app regression or an i18n/npm change.

The demo creates a FREQ=WEEKLY;BYDAY=MO,WE,FR task relative to the browser's current date. The model advances its concrete scheduled date to the next occurrence. That occurrence correctly renders as is-recurring-next; only other generated occurrences render as is-recurring-pattern. From Thursday through Saturday there are no generated patterns left in the current week. The test nevertheless required one in that week.

git log 21f38974..origin/main contains only the delayed-deletion fix (#318) and byte-identical i18n/UI package swap (#320), neither of which changes recurrence expansion or this fixture. The calendar rolled from Wednesday (passing) into Thursday (failing).

Fix

  • Exercise the next calendar week, where generated patterns exist regardless of today's weekday.
  • Run the same edit-scope/materialization assertions for every weekday, with a fixed browser date and UTC timezone. The chosen week also exercises a next-week month boundary.
  • Keep the pattern selector and all scope, focus, replacement-count and error assertions intact. No production application code or dependencies changed.

Verification

  • Before the navigation fix: controlled dates October 25–28 passed; October 29–31 reproduced the missing-pattern failure (4 pass, 3 fail).
  • After: local dev fixture 7 pass, desktop-only mobile cases skipped as before.
  • rpnpm verify PASS: i18n, release checks (394 pass / 1 skip), formatting, typecheck, lint, 1,938 Vitest tests plus overall/layer coverage gates, 4,982 TaskNotes conformance cases and mdbase oracle, production build.
  • rpnpm --pull dist build:e2e PASS.
  • Failing Playwright spec against the pulled built artifact 7 pass / 7 intentional mobile skips, using isolated loopback port 6392.

No workflow dispatches, deployments, store submissions or administrative bypasses.

@callumalpass
callumalpass merged commit f42cf11 into main Oct 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant