Repository navigation
Fix weekday-dependent recurring edit scope E2E fixture - #321
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
This is a date-dependent E2E fixture assumption, not a recurring-calendar app regression or an i18n/npm change.
The demo creates a
FREQ=WEEKLY;BYDAY=MO,WE,FRtask relative to the browser's current date. The model advances its concrete scheduled date to the next occurrence. That occurrence correctly renders asis-recurring-next; only other generated occurrences render asis-recurring-pattern. From Thursday through Saturday there are no generated patterns left in the current week. The test nevertheless required one in that week.git log 21f38974..origin/maincontains only the delayed-deletion fix (#318) and byte-identical i18n/UI package swap (#320), neither of which changes recurrence expansion or this fixture. The calendar rolled from Wednesday (passing) into Thursday (failing).Fix
Verification
rpnpm verifyPASS: i18n, release checks (394 pass / 1 skip), formatting, typecheck, lint, 1,938 Vitest tests plus overall/layer coverage gates, 4,982 TaskNotes conformance cases and mdbase oracle, production build.rpnpm --pull dist build:e2ePASS.No workflow dispatches, deployments, store submissions or administrative bypasses.