Fix the verify email user action - #476
Merged
Merged
Conversation
The action closure type-hinted an unused Builder $query parameter. Filament resolves that parameter as the selected records query, which record actions do not provide, so clicking the action threw a LogicException instead of sending the verification email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogicExceptioninstead of sending the verification email:Builder $queryparameter. Filament resolves aBuilderparameter as the selected records query, which a record action does not provide, so evaluating the closure failed before the notification was sentBuilderimport) and give the closure an explicitvoidreturn type, matching the neighbouringreset-two-factoractionVerifyEmailnotification is sentValidation
mainwith theLogicExceptionabove and passes with the fixvendor/bin/pest: 1135 passed (4162 assertions), aftercomposer buildvendor/bin/pint --test: passedvendor/bin/phpstan analyse src/Filament/Resources/Users/UserResource.php: no errors