Repository navigation
docs(dev): document the dev GitHub OAuth redirect URIs - #1102
Merged
Merged
Conversation
GitHub is the only provider. The dev OAuth app now registers the local.uploadrouter.dev and 127.0.0.1:4321 callbacks, so the 8788 BETTER_AUTH_URL workaround is no longer needed.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1101. The local docs described a Google provider that doesn't exist and a dev GitHub OAuth app whose only callback was
127.0.0.1:8788, which didn't match the same-originredirect_urieither stack sends.The dev GitHub OAuth app now registers:
https://local.uploadrouter.dev/api/auth/callback/github(wildcard on, so worktree hosts work)http://127.0.0.1:4321/api/auth/callback/github(raw stack)http://127.0.0.1:8788/api/auth/callback/github(legacy)docs/local-dev.mdnow lists those URIs and drops the "pointBETTER_AUTH_URLback at 8788" workaround. It also drops the Google mention. The matching comment inscripts/dev-stack-common.mjsis updated too. Docs and comments only.