Repository navigation
Conversation
checktest compiled FilePaths with OS separators, so on Windows a file in a subdirectory was named with backslashes and didn't match the forward-slash names used to tell FilePaths from imports, which marked it as an import. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
mkanat
marked this pull request as ready for review
October 21, 2026 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
checktestmarks aFilePathsentry in a subdirectory, such asfoo/bar.proto, as an import, so rules that skip imports never check it.compilegives the compiler OS-separated paths, so the file descriptor is namedfoo\bar.proto, but it looks up imports by forward-slash paths.This passes forward-slash paths to the compiler, so file names match and use the same separators as everywhere else in
.protofiles, and adds a test with a file in a subdirectory.🤖 Generated with Claude Code