chore(deps): bump com.puppycrawl.tools:checkstyle from 13.4.2 to 14.3.0

checkstyle-suppressions.xml

@@ -16,6 +16,24 @@
     <suppress checks="ParameterName"
               files="(probe|builder|options|progress)[\\/]"/>
 
+    <!-- Keep established public method names exempt from Google's naming rule. -->
+    <suppress checks="GoogleMethodName" files="FFmpegStream\.java"
+              message="Method name 'getHasBFrames'.*"/>
+    <suppress checks="GoogleMethodName" files="FFmpegStream\.java"
+              message="Method name 'getRFrameRate'.*"/>
+    <suppress checks="GoogleMethodName" files="FFmpegBuilder\.java"
+              message="Method name 'setVBR'.*"/>
+    <suppress checks="GoogleMethodName" files="AbstractFFmpegOutputBuilder\.java"
+              message="Method name 'setBFrames'.*"/>
+    <suppress files="FFmpeg\.java" checks="GoogleMethodName"
+              message="Method name 'isFFmpeg'.*"/>
+    <suppress files="FFprobe\.java" checks="GoogleMethodName"
+              message="Method name 'isFFprobe'.*"/>
+    <suppress files="NutDataInputStream\.java" checks="GoogleMethodName"
+              message="Method name 'resetCRC'.*"/>
+    <suppress files="NutDataInputStream\.java" checks="GoogleMethodName"
+              message="Method name 'getCRC'.*"/>
+
     <!-- NUT format parser uses spec-matching names for readability -->
     <suppress checks="MemberName|ParameterName|LocalVariableName|AbbreviationAsWordInName|GoogleNonConstantFieldName"
               files="nut[\\/]"/>

pom.xml

@@ -292,7 +292,7 @@
                         <dependency>
                             <groupId>com.puppycrawl.tools</groupId>
                             <artifactId>checkstyle</artifactId>
-                            <version>13.4.2</version>
+                            <version>14.3.0</version>
                         </dependency>
                     </dependencies>
                     <configuration>

src/main/java/net/bramp/ffmpeg/FFmpeg.java

@@ -134,7 +134,7 @@ public boolean isFFmpeg() throws IOException {
    * @throws IllegalArgumentException if this is not the official ffmpeg binary.
    * @throws IOException If a I/O error occurs while executing ffmpeg.
    */
-  private void checkIfFFmpeg() throws IllegalArgumentException, IOException {
+  private void checkIfFfmpeg() throws IllegalArgumentException, IOException {
     if (!isFFmpeg()) {
       throw new IllegalArgumentException(
           "This binary '" + path + "' is not a supported version of ffmpeg");
@@ -143,7 +143,7 @@ private void checkIfFFmpeg() throws IllegalArgumentException, IOException {
 
   /** Returns the list of supported codecs. */
   public synchronized @Nonnull List<Codec> codecs() throws IOException {
-    checkIfFFmpeg();
+    checkIfFfmpeg();
 
     if (this.codecs == null) {
       codecs = new ArrayList<>();
@@ -173,7 +173,7 @@ private void checkIfFFmpeg() throws IllegalArgumentException, IOException {
 
   /** Returns the list of supported filters. */
   public synchronized @Nonnull List<Filter> filters() throws IOException {
-    checkIfFFmpeg();
+    checkIfFfmpeg();
 
     if (this.filters == null) {
       filters = new ArrayList<>();
@@ -213,7 +213,7 @@ private void checkIfFFmpeg() throws IllegalArgumentException, IOException {
 
   /** Returns the list of supported formats. */
   public synchronized @Nonnull List<Format> formats() throws IOException {
-    checkIfFFmpeg();
+    checkIfFfmpeg();
 
     if (this.formats == null) {
       formats = new ArrayList<>();
@@ -242,7 +242,7 @@ private void checkIfFFmpeg() throws IllegalArgumentException, IOException {
 
   /** Returns the list of supported pixel formats. */
   public synchronized List<PixelFormat> pixelFormats() throws IOException {
-    checkIfFFmpeg();
+    checkIfFfmpeg();
 
     if (this.pixelFormats == null) {
       pixelFormats = new ArrayList<>();
@@ -275,7 +275,7 @@ public synchronized List<PixelFormat> pixelFormats() throws IOException {
 
   /** Returns the list of supported channel layouts. */
   public synchronized List<ChannelLayout> channelLayouts() throws IOException {
-    checkIfFFmpeg();
+    checkIfFfmpeg();
 
     if (this.channelLayouts == null) {
       Process p = runFunc.run(ImmutableList.of(path, "-layouts"));
@@ -305,7 +305,7 @@ protected ProgressParser createProgressParser(ProgressListener listener) throws
 
   @Override
   public void run(List<String> args) throws IOException {
-    checkIfFFmpeg();
+    checkIfFfmpeg();
     super.run(args);
   }
 

src/main/java/net/bramp/ffmpeg/FFprobe.java

@@ -77,7 +77,7 @@ public FFmpegProbeResult probe(
   // TODO: Add Probe Inputstream
   /** Probes media using the supplied arguments and returns the result. */
   public FFmpegProbeResult probe(List<String> args) throws IOException {
-    checkIfFFprobe();
+    checkIfFfprobe();
 
     Process p = runFunc.run(path(args));
     try {
@@ -118,7 +118,7 @@ public boolean isFFprobe() throws IOException {
    * @throws IllegalArgumentException if this is not the official ffprobe binary.
    * @throws IOException If a I/O error occurs while executing ffprobe.
    */
-  private void checkIfFFprobe() throws IllegalArgumentException, IOException {
+  private void checkIfFfprobe() throws IllegalArgumentException, IOException {
     if (!isFFprobe()) {
       throw new IllegalArgumentException(
           "This binary '" + path + "' is not a supported version of ffprobe");
@@ -127,7 +127,7 @@ private void checkIfFFprobe() throws IllegalArgumentException, IOException {
 
   @Override
   public void run(List<String> args) throws IOException {
-    checkIfFFprobe();
+    checkIfFfprobe();
     super.run(args);
   }
 

src/test/java/net/bramp/ffmpeg/FFmpegTest.java

@@ -2,6 +2,7 @@
 
 import static org.hamcrest.Matchers.hasItem;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 import static org.mockito.Mockito.*;
 import static org.mockito.hamcrest.MockitoHamcrest.argThat;
@@ -60,6 +61,7 @@ public static <T> List<T> argThatHasItem(T s) {
   public void testVersion() throws Exception {
     assertEquals("ffmpeg version 0.10.9-7:0.10.9-1~raring1", ffmpeg.version());
     assertEquals("ffmpeg version 0.10.9-7:0.10.9-1~raring1", ffmpeg.version());
+    assertTrue(ffmpeg.isFFmpeg());
 
     verify(runFunc, times(1)).run(argThatHasItem("-version"));
   }

src/test/java/net/bramp/ffmpeg/FFprobeTest.java

@@ -88,6 +88,7 @@ public void testVersion() throws Exception {
         "ffprobe version 3.0.2 Copyright (c) 2007-2016 the FFmpeg developers", ffprobe.version());
     assertEquals(
         "ffprobe version 3.0.2 Copyright (c) 2007-2016 the FFmpeg developers", ffprobe.version());
+    assertTrue(ffprobe.isFFprobe());
 
     verify(runFunc, times(1)).run(argThatHasItem("-version"));
   }