Repository navigation
Move module skills to repo-root skills/ for the Vercel skills CLI - #995
Merged
Merged
Conversation
The bmad-loop-* skills and the bmod-bmad-loop record move from src/bmad_loop/data/skills/ to skills/, a default discovery path of `npx skills add`, so the repo installs without relying on the .claude-plugin manifest. - pyproject: wheel force-include maps skills/ to bmad_loop/data/skills, so `bmad-loop init` still lays them down from the installed package. - install.skills_root(): single lookup for the bundled skills; falls back to the checkout's skills/ in an editable install, where force-include does not apply. All call sites route through it. - bmod.toml sources, marketplace.json, seed/sync/release scripts, tests and docs point at the new path. - Drop the repo-root module.yaml mirror; the BMAD installer finds skills/bmad-loop-setup/assets/module.yaml directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
bmad-loop-*skills and thebmod-bmad-loopmodule record fromsrc/bmad_loop/data/skills/to a repo-rootskills/directory.skills/is a default discovery path of the VercelskillsCLI, sonpx skills add bmad-code-org/bmad-loopfinds them without going through.claude-plugin/marketplace.json.[tool.hatch.build.targets.wheel.force-include]mapsskills/tobmad_loop/data/skills, sobmad-loop initstill installs the skills from the package.install.skills_root(): one lookup for the bundled skills. An editable install (uv sync) skipsforce-include, so in a source checkout it falls back to the repo'sskills/. Every formerresources.files("bmad_loop.data").joinpath("skills")site now goes through it.bmod.tomlsource/update_sourcenow point togithub:bmad-code-org/bmad-loop/skills.marketplace.jsonuses the new paths.seed_skills.py,sync_version.py,release.py, the tests, the ruff exclude, AGENTS.md/CONTRIBUTING/setup and sweep guides, andskills/README.md.module.yamlmirror dropped: it existed only because the old canonical copy was nested too deep for the BMAD installer.skills/bmad-loop-setup/assets/module.yamlis a path the installer discovers directly.sync_version.pyno longer stamps or checks the mirror, andrelease.pyno longer stages it.Verification
npx skills@1.7.2 add <clean tracked-files export> --listfinds all 4 skills, both with and without.claude-plugin/.npx skills add … --skill '*' -a claude-code --copy -yinstalls every file, includingassets/andhelp/.skills_root()tosite-packages/bmad_loop/data/skills.uv run pytest -n logical: 16691 passed, 116 skipped.uv run pyright: 0 errors.trunk check: clean.sync_version.py --checkandrelease.py checkpass.npx skills add bmad-code-org/bmad-loopreads the default branch, so the new layout takes effect for installers once this merges.