Repository navigation
Conversation
|
Initial automated review · Aster Hi @satran004, thanks for the PR! 🙏 This is an automatic first check by an AI reviewer. It does not replace maintainer review and may be wrong. Noted that this is a draft. Reviewed commit: Issues found:
Not tested: Code was read only; builds, lint reproduction, Wasm proofs, and browser tests were not run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds runtime circuit compilation and typed authoring to the modular Wasm SDK. TypeScript definitions and portable Java graphs reach the existing Java symbolic APIs, R1CS compiler, witness calculator and Groth16 prover. Fixed arrays support the existing Poseidon Merkle gadget. The default profile proves depths 1/2, with a confirmed local Cardano claim; a separate research image now proves depths 8/16/32 in Node, Chromium, Firefox and JVM at 6g/8g.
Stacked on #92 (
design/adr-0057-wasm-and-native-bindings, base844a0625). Remains draft: measured frontend/application slices are implemented; independent review and broader roadmap gates remain open. No core compiler, hash/curve equations or proof security parameters changed.Implemented:
@zeroj/circuit, selected compiler/prover image and authoring lint.Validation:
Larger-profile Chromium feasibility samples, seconds:
Import dominates: Firefox depth 32 loaded in 523.097 s, then proved in 14.092 s. Samples ran concurrently on a shared desktop; they are not isolated engine rankings or p95 estimates. The research driver explicitly uses a 600 s per-call deadline; normal defaults are unchanged.
The larger-Merkle report includes all timings, memory methodology, JFR allocation attribution and reproducible commands. A read-only census found unused wire columns and substantial compression potential; wire compaction is a separate core proposal, not implemented here. Compression measurements do not establish reduced parsed-key memory or validation cost.
M3/Cardano, M2 and M1 remain historical baselines. The Cardano guide documents isolated JuLC/CCL dependencies; core dependency versions are unchanged.
Security/scope: disposable setup, published test witnesses and experimental variable-time secret operations. Membership remains reusable on other deposits and the signer is public; same-UTxO rejection is not a nullifier protocol. No anonymous/private-state, mainnet-cost, production-readiness or post-quantum claim. No npm publication; raw keys/proofs/results/images/traces remain ignored. Default promotion, hostile-input heap containment, actual mobile/Safari, ceremony/side-channel assurance, independent review, broader SHA-2/BLAKE2b and private-state protocols remain open.