Repository navigation
chore(deps): lint with shared-config 0.13 and emit renamed comment rule - #37
Open
maxholman[bot] wants to merge 1 commit into
Open
maxholman[bot] wants to merge 1 commit into
maxholman[bot] wants to merge 1 commit into
Conversation
The generated directive named `block65/no-comment-punctuation`, which oxlint-plugin 0.16 renamed to `max-comment-colons-and-semicolons`. It now names the new rule, and the fixtures are regenerated with oxlint 1.93 and plugin 0.18, so their directives list only the rules that fire there. The new config's reports are fixed: `utf-8` encoding names, a version parse and a digit split that now handle a missing part, and a writer that emits `null` for a null argument instead of `undefined`. Four fallbacks that name a TypeScript type or a message word keep their literal, with a reason at each site. Co-Authored-By: LLM <noreply@block65.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
oxlint-disabledirective namedblock65/no-comment-punctuation, which oxlint-plugin 0.16 renamed tomax-comment-colons-and-semicolons. The old name works only as a deprecated alias, until the plugin's next breaking release.lib/oxlint.tsnames the new rule.no-comment-historyno longer fires inhono.ts.text-encoding-identifier-case(11):"utf8"becomes"utf-8".no-sentinel-fallback(3):canStateItemSchemaandnumericLiteralnow handle a missing part explicitly, instead of defaulting it to0or"".no-open-string-fallback(5): the writer emitsString(item), which also fixes a null argument being written asundefined. The other four fall back to a TypeScript type name or a message word, which is the correct value there, so each keeps it with a reason at the site.Regenerating after the code fixes leaves the fixtures byte-identical.
just checkpasses: 88 tests.