fix(mobile): stop thread down-arrow flicker - #7573
Open
CharryLee0426 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Charlie Li <charlie.li@bytedance.com>
🔐 Codex Security Review
|
Author
|
@klopez4212 could you take a look when you have a chance? This fixes #7314 and relates to your jump-to-latest work in #6807. I’ve included before/after recordings, tested on iOS and Android, and added regression coverage for thread settling and arrow visibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7314. Related: #6807.
Stops the down-arrow button from flashing when opening mobile threads with long messages. The thread settles before it becomes visible, and the arrow stays stable during automatic scrolling. It still appears when there is content below the screen and lets you jump to the bottom.
Testing
just mobile-checkpassed.just mobile-testpassed: 2,105 tests, including regressions for thread entry, scrolling, new replies, deep links, and the jump-to-bottom button.just cistopped at the unchanged desktop testuseKnownAgentPubkeys.test.mjs; that test passed when rerun on its own.Before the fix
01_before_installing_fixed_ver.mp4
Fixed version: end-to-end test
02_fixed_version_e2e.mp4
Reinstalled published version: comparison
03_reinstalled_online_ver.mp4