Repository navigation
Conversation
Set `decorations: false` on the window so the redundant native title bar is removed; the in-app header already provides the close button. Add `window::drag` handling so the borderless window stays movable by dragging the main header or dialog title strips. Closes #23 Co-authored-by: so1ve <58381667+so1ve@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unexpected title bar from UI
Remove native title bar in favor of in-app header
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window renders a redundant native OS title bar (with its own min/max/close controls) above the in-app header, which already provides a close button. This makes the window borderless and keeps it movable via in-app drag surfaces.
Changes
Window setup (
app.rs): setdecorations: falseinwindow::Settingsso the native title bar is not rendered.Window dragging (
app.rs): added aDragWindowmessage handled viawindow::drag(id), plus anApp::drag()helper returning the message when a window exists. A borderless window has no native drag handle, so dragging must be initiated in-app:components/header.rs— main header row (title, status badge, settings, ×) wrapped in amouse_areathat starts the drag; child buttons still capture their own presses, so 设置 and × keep working.components/dialog.rs—dialog::headernow accepts adrag: Option<Message>applied to the title strip only, excluding the close button so its click isn't swallowed by the drag.views/settings.rs,views/update.rs,components/feedback.rs— passapp.drag()through to their dialog headers (settings, update, and notice dialogs all draggable).Closing behavior is unchanged: the in-app × button, Esc, and tray menu still close the window to the tray.