Skip to content

docs: add maintainers section to CONTRIBUTING.md - #2328

Open
notmandatory wants to merge 1 commit into
bitcoindevkit:masterfrom
notmandatory:docs/update_contributing
Open

notmandatory wants to merge 1 commit into
bitcoindevkit:masterfrom
notmandatory:docs/update_contributing

Conversation

@notmandatory

Copy link
Copy Markdown
Member

Description

I borrowed from the rust-bitcoin CONTRIBUTING.md file to add a maintainers section to our CONTRIBUTING.md file. The main points I wanted to clarify are:

  1. a maintainer can merge a PR based on the reviews of other project contributors they trust to competently review and test changes. They do not need to do a detailed review and test each and every PR themselves.
  2. a maintainer must ensure "rough consensus" is reached on the need for and correctness of a PR.
  3. at least one maintainers must ACK a PR who is not the original author.

Notes to the reviewers

These changes match recent bitcoindevkit/bdk_wallet#521 and I'll propose the same change on our other repos.

Changelog notice

  • Add maintainers section to CONTRIBUTING.md file.

Before submitting

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.84%. Comparing base (e417c43) to head (fcf1e44).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2328   +/-   ##
=======================================
  Coverage   78.84%   78.84%           
=======================================
  Files          31       31           
  Lines        6060     6060           
  Branches      288      288           
=======================================
  Hits         4778     4778           
  Misses       1203     1203           
  Partials       79       79           
Flag Coverage Δ
rust 78.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant