Repository navigation
Conversation
Decode the 135 newline entities in the one-line Emergency Multisig payout tool source so each element can be reviewed separately. The rendered page is unchanged apart from entity spelling. This article is an additional historical source, so its receipt lives in additional-articles.json. Let a source-formatting record apply to additions and rebuild the exact imported bytes before checking that receipt. The receipt hash itself is not changed.
Stop the restored 2021 guide from telling traders to copy wallet private keys into a text editor and a bisqWallet.txt file. Point the Get private keys section and the signing step to the local Locate key in wallet and Generate Signature actions, and keep the warning, scoped to the original 2021 process. Sources: Bisq 1 v1.10.11 SignPane.java L76-L138 (local key lookup and signing), BuildPane.java L106-L135 (signature assembly) and ImportPane.java L70-L80 (import fills the inputs), commit ea9d5dff. Keep original source and review snapshots unchanged. Leave publication blocked pending support review and explicit acceptance of these edits.
The receipt check for the three additional articles undid recorded line breaks without checking the offsets. A string offset made slice() drop text, so inserted content could vanish before the receipt hash was taken and an edited article passed the gate. Apply the same checks as for the 209 originals: an array of safe integers inside the file, and the undone text must hash to the recorded imported file. A test covers string, fractional and missing offsets with a synthetic record.
LOCATE KEY IN WALLET searches only the running wallet, so switching data directories before the payout breaks it; say so next to the Warning's advice to switch. If the field shows Not found in wallet, point to the data directory and the mediator instead of any other key source. The SIGN screen shows the private key in a plain text field, so copy the signature with its icon instead of sending a screenshot. In the v1.10.11 source, the wallet listing uses the password entered at startup, so the password does not have to be removed.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 10, 2026
Resolves two conflicts with the accepted-edit receipts (bisq-network#96): - CONTRIBUTING.md: keeps this branch's sentence about additional articles and the new Accepted editorial changes section from main. - scripts/check-source-fidelity.mjs: imports both additionalArticles and the accepted-edits helpers. With the article at its formatting-only commit (745df9b), npm test (68) and npm run build pass, so the remaining check failure is only the unreceipted wording change this PR proposes.
This was referenced Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #85, which was opened from a branch in this repository. The changes are the same; the commits were re-signed with corrected authorship.
Addresses migration note
local-signing-not-private-key-collection("Manual payout: local signing") for the restored 2021 article Emergency Multisig payout tool (src/content/docs/wiki/emergency-multisig-payout-tool.md, wiki revision 2011, 20 January 2021).The restored guide tells traders to copy their wallet's private keys into a text editor, save the key in a
bisqWallet.txtfile and remove the wallet password. This PR replaces that part with the local key lookup and signing that Bisq 1 v1.10.11 provides, consistent with #105 (Manual payout). Title, headings, step order, tables, the Precautions section and the Warning's advice are unchanged.Commits
entities into line breaks, using the same rule as the formatting baseline. The rendered page differs frommainonly in writing a newline as\ninstead of .This is one of the three additional historical articles, whose receipt is
output_sha256inmigration/additional-articles.json, not the 209-article fidelity manifest. So the commit also lets amigration/source-formatting.jsonrecord belong to an additional article (scripts/check-source-fidelity.mjs,scripts/lib/additional-articles.mjs), adds a test and one sentence to CONTRIBUTING.md. The receipt hash itself is not changed.slice()drop text, so inserted content could vanish before the receipt hash was taken and an edited article passed the gate. It now applies the same checks as for the 209 originals (an array of safe integers inside the file, and the undone text must hash to the recorded imported file), with a test using a synthetic record.Wording changes
priv HEX=, save inbisqWallet.txt), and the note that a password-protected wallet must have its password removed.privateKeyHexfield; GENERATE SIGNATURE then signs on your computer. Share only the resulting signature: never send a private key or seed words to the mediator or anyone else. / If the field shows Not found in wallet, check that Bisq is running with the data directory you used for this trade; do not paste a key from anywhere else, and ask the mediator for help. You do not need to remove your wallet password: Bisq uses the password you entered at startup. / This replaces the original 2021 steps, which copied wallet data including private keys into a text editor and saved the key in a bisqWallet.txt file.The removed steps remain in the preserved original wikitext (
public/wiki-source/emergency-multisig-payout-tool.wiki.txt), linked from the page's "Source and history" section.Sources
All at Bisq commit
ea9d5dff90c99ac462f2b0a7bf9ef92683956619, the target of tagv1.10.11.privateKeyHex, or writes "Not found in wallet".privateKeyHexis a plain text field on the same screen as the signature, which has a copy icon. "Generate Signature" computes the signature locally.gradle/verification-metadata.xml) decrypts a key with the given AES key when it formats the listing.What was checked and what was not
depositTxLegacycheckbox and computed fee fields, which the 2021 table does not list;depositTxIdis listed.Expected check results
checkfails, and will keep failing until maintainers decide how edits to the additional historical articles are accepted. Accepted-edit receipts (#96, #183) cover only the 209 restored articles. This article is one of the three additional historical articles (migration/additional-articles.json, markedhistorical_only), so no receipt can accept its wording yet. On this branch,node scripts/check-source-fidelity.mjsstops withadditional rendered article drift: emergency-multisig-payout-tool (formatted source), and thenpm testcases that run the gate on the committed files fail for the same reason. The receipt was not refreshed to hide the difference.Two ways forward: