Repository navigation
Conversation
Decode the 15 newline entities in the one-line Backing up your wallet seed source so its paragraphs and the template placement can be reviewed separately. The rendered page is unchanged apart from entity spelling. Record the offsets in source-formatting.json so the fidelity check rebuilds the exact original bytes. Original hashes are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcbFo7FxLxPktLKLFLLxae
The archived Wallet derivation paths template, rendered in three wallet articles, lists only m/44'/142'/0' for BSQ. Add one sentence after each placement giving the BSQ SegWit path m/44'/142'/1' and saying that the list is not a complete recipe for restoring a Bisq wallet in other software. The template and its receipts stay unchanged. Sources: Bisq 1 v1.10.11 BisqKeyChainGroupStructure.java L32-L74 (BTC and BSQ legacy and SegWit paths), WalletConfig.java L434-L450 (new wallets use SegWit) and L566-L605 (legacy wallets gain a SegWit keychain), commit ea9d5dff. Keep original source and review snapshots unchanged. Leave publication blocked pending support review and explicit acceptance of these edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcbFo7FxLxPktLKLFLLxae
Both SegWit paths use purpose 44' with native P2WPKH scripts, which other wallets will not infer from the path. Say so, refer to "the paths above" because the template renders as paragraphs, not a list, and add the warning Bisq's own Wallet info screen gives: other wallets show BSQ as ordinary bitcoin, and spending it there will probably lose the BSQ.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Collaborator
Author
|
Automated note: moved to #99, opened from a fork with the same changes and corrected commit authorship. Please continue the review there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses migration note
wallet-derivation-template-incomplete("The historical BSQ derivation list is incomplete") for Backing up your wallet seed, Restoring your wallet from seed and Wallet.Where the list is
The list is not in the article text. Each article has one
{{Wallet derivation paths}}/{{Wallet_derivation_paths}}call, rendered at build time from archived template 261 (revision 2003, 6 January 2021,public/wiki-source/archive-templates/261.wiki.txt). It gives BTC SegWitm/44'/0'/1', BTC legacym/44'/0'/0'and only one BSQ path,m/44'/142'/0'.The template and its rendering are hash-locked historical sources, so the correction is one paragraph placed directly after the template in each article. The template block, including its "Historical template from the 14 October 2026 archive" line, stays as it is.
Commits
backing-up-your-wallet-seed.mdwas still one source line. Its 15 entities become line breaks, recorded inmigration/source-formatting.jsonlike the other formatting records (95 onmain, 96 here). The rendered page differs frommainonly in writing a newline as\ninstead of . The other two articles were already formatted.Wording change
Added after the template placement in all three articles (in Wallet, before the "Watch keys" line):
Why the review changed it: both SegWit paths use purpose
44'with native P2WPKH scripts, which other wallets will not infer from the path (BIP84 would use84'); the template renders as paragraphs, so "this list" could attach to the wrong list in Wallet; and in Restoring the paragraph sits under "Restoring to a non-Bisq wallet", where a reader who imports the BSQ path elsewhere sees an ordinary BTC balance. The last sentence follows Bisq's own Wallet info warning.Nothing is removed. The template's own warning against sending BSQ to a non-Bisq wallet still appears directly above.
Sources
At Bisq commit
ea9d5dff90c99ac462f2b0a7bf9ef92683956619(tagv1.10.11):m/44'/0'/0'(legacy) andm/44'/0'/1'(SegWit); BSQm/44'/142'/0'(legacy) andm/44'/142'/1'(SegWit); P2WPKH maps to the SegWit path.core/src/main/resources/i18n/displayStrings.properties).What was checked and what was not
AddressEntryList.javaL139-L142), which suggests it does, but the bitcoinj fork's builder was not read. The paragraph does not say "only", so it holds either way.Overlap
git merge-treemerges this branch cleanly with Add current seed-restore safeguards #8 and with Distinguish external funding from avoiding the wallet #16 (rechecked at the last commit).seed-is-not-application-backupand Explain entries omitted by application backup #7/Add current seed-restore safeguards #8 cover application data and restore preconditions; this PR adds only the paths.Expected check results
npm test37/37 pass;DOCS_SITE=https://hiciefte.github.io DOCS_BASE=/bisq-docs/ npm run buildpasses.npm test37/37 pass. The restoration gate fails as intended, with four findings:src/content/docs/wiki/backing-up-your-wallet-seed.md: formatted source file driftsrc/content/docs/wiki/restoring-your-wallet-from-seed.md: formatted source file driftsrc/content/docs/wiki/wallet.md: formatted source file driftmigration/restoration-fidelity.json: expected 130 contextual image occurrences(128 !== 130). This one follows from the first two: the image count skips articles whose check failed, and two of the edited articles have one image each. Add current seed-restore safeguards #8 shows the same pattern (129 !== 130).Running the remaining build steps directly (template, section, link and category checks, browse indexes,
astro build,check-site.mjs) passes: 601 pages. The original hashes were not refreshed.