Repository navigation
Update lockfiles and use strict PHPUnit assertions - #1150
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## 8.x #1150 +/- ##
=========================================
Coverage 88.40% 88.40%
Complexity 1519 1519
=========================================
Files 158 158
Lines 4260 4260
=========================================
Hits 3766 3766
Misses 494 494
*This pull request uses carry forward flags. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the maintained lockfiles and replace ten empty assertions with type-specific checks required by phpstan/phpstan-phpunit 2.1.1. Arrays use strict comparisons, the multicast report uses assertCount(), and the string UID uses assertNotSame('').
Supersedes #1137.
Validation: PHPStan, configured lint, and 64 focused unit tests with 93 assertions pass locally on PHP 8.5. Integration tests require credentials and were skipped.