Conversation
jayrulez
marked this pull request as draft
September 20, 2026 21:59
jayrulez
marked this pull request as ready for review
September 20, 2026 22:52
Contributor
Author
|
Same question here @bfiete . Should I drop these tests from the PR? |
Collaborator
|
Nah these are ok - they are more like proper "general" tests rather than laser-targeted tests for one specific bug. |
Collaborator
|
Except now this has merge conflicts. |
Contributor
Author
|
Yeah, touched the same line as a previous. I will rebase |
CeContext::GetReflectType populated the alias and then built its type data, which reads through to the aliased type: WantsGCMarking on an alias forwards to it. In a resolve-only pass the aliased type can still be undefined at that point, which asserts in a debug build and carries on with an undefined type in a release one. Populate the target too. Seen from an [OnCompile(.TypeInit)] generator reflecting a typealias to a function type in the IDE's background pass.
jayrulez
force-pushed
the
fix/comptime-reflect-alias-target-unpopulated
branch
from
September 21, 2026 12:47
f12dc9c to
68422ce
Compare
Contributor
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CeContext::GetReflectType populated the alias and then built its type data, which reads through to the aliased type: WantsGCMarking on an alias forwards to it. In a resolve-only pass the aliased type can still be undefined at that point, which asserts in a debug build and carries on with an undefined type in a release one. Populate the target too.
Seen from an [OnCompile(.TypeInit)] generator reflecting a typealias to a function type in the IDE's background pass.