Skip to content

Add VMmanager 6 integration with NetBox - #597

Closed
Sivolen wants to merge 4 commits into
bb-Ricardo:developmentfrom
Sivolen:main
Closed

Sivolen wants to merge 4 commits into
bb-Ricardo:developmentfrom
Sivolen:main

Conversation

@Sivolen

@Sivolen Sivolen commented Oct 13, 2026

Copy link
Copy Markdown

No description provided.

@semx semx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the integration. A few things about the shape of the PR before reviewing the source itself:

  • Adding a source is a bigger decision, so I'd leave that to @bb-Ricardo. It would help to know where VMmanager 6 is used and whether you'd look after the source going forward.
  • Several changes affect every source and aren't specific to VMmanager: catching source errors in netbox-sync.py, loading tags before creating them in connection.py, the display name of unscoped clusters and description on devices in object_classes.py, and empty MAC handling in source_base.py. Each would be easier to review as its own PR, with the problem it fixes and a test.
  • netbox-sync.py, scripts/publi.sh and scripts/set_version.sh lose their executable bit.
  • The branch is based on main at 1.9.1 and is six commits behind development; please rebase onto development and add tests for the new source (tests/ has examples for the VMware and check_redfish sources).
  • A short description of what the source syncs, objects, fields and config options, would help a lot.

@Sivolen Sivolen closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants