Skip to content

fix(VMware): query network hints of all host NICs #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
semx merged 2 commits into from
Oct 8, 2026
Merged

fix(VMware): query network hints of all host NICs #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89d019a
adds @semx to CODEOWNERS
bb-Ricardo Oct 3, 2026
189aad5
fix(VMware): query network hints of all host NICs
tfoks Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

* @bb-ricardo
* @semx @bb-ricardo


/sources/hetzner/ @SerhiiZahuba
Expand Down
6 changes: 3 additions & 3 deletions module/sources/vmware/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2433,10 +2433,10 @@ def add_host(self, obj):
pnic_hints = dict()
# noinspection PyBroadException
try:
for hint in obj.configManager.networkSystem.QueryNetworkHint(""):
for hint in obj.configManager.networkSystem.QueryNetworkHint():
pnic_hints[hint.device] = hint
except Exception:
pass
except Exception as e:
log.debug(f"Unable to query network hints (CDP/LLDP) of host '{name}': {e}")

pnic_list = grab(obj, "config.network.pnic", fallback=list())
if self.settings.skip_host_nics is True:
Expand Down
Loading