Repository navigation
Initial Support for Slurm 26.05 - #742
Merged
Merged
Conversation
Slurm 26.05 adds two keys to each job in the `SLURM_RESUME_FILE`: - [exclusive](SchedMD/slurm@7f63a8c) - [priority](SchedMD/slurm@219d033) Changelog: [26.05.0rc1](https://github.com/SchedMD/slurm/blob/476de143d0fd4137fd4606882a68443965529ba3/CHANGELOG/slurm-26.05.md?plain=1#L332) ("Add job priority value to SLURM_RESUME_FILE"), [L465](https://github.com/SchedMD/slurm/blob/476de143d0fd4137fd4606882a68443965529ba3/CHANGELOG/slurm-26.05.md?plain=1#L465) ("Add exclusive to the SLURM_RESUME_FILE"). Code: [power_save.c](https://github.com/SchedMD/slurm/blob/slurm-26-05-5-1/src/slurmctld/power_save.c#L650-L671). `SlurmResumeJob(**job)` raised `TypeError: unexpected keyword argument 'exclusive'`, which failed the whole resume. As a result, ParallelCluster could not launch dynamic nodes with Slurm 26.05. This commit: - [Must have] Accepts `exclusive` and `priority`, and ignores any key a future Slurm adds, so new Resume File fields no longer break scaling. - [Cleanup BTW] Removes `SlurmResumeJob.is_exclusive()`. It had no caller since aws#574 (job-level scaling for all jobs). Backward compatible: Slurm 25.11 doesn't emit either key, so both default to `None` and parsing is unchanged. Note: this is an initial support for Slurm 26.05 to allow ParallelCluster scale correctly. This commit doesn't consider incorporating new Slurm features.
hanwen-cluster
force-pushed
the
developslurm265
branch
from
October 14, 2026 13:09
4e66cad to
012b2c5
Compare
hanwen-cluster
commented
Oct 14, 2026
Comment on lines
-143
to
-144
| def is_exclusive(self): | ||
| return self.oversubscribe == JobOversubscribe.NO |
Contributor
Author
There was a problem hiding this comment.
This is dangling code, so is removed.
See details in the PR description
hgreebe
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Slurm 26.05 adds two keys to each job in the
SLURM_RESUME_FILE:Changelog: 26.05.0rc1 ("Add job priority value to SLURM_RESUME_FILE"), L465 ("Add exclusive to the SLURM_RESUME_FILE"). Code: power_save.c.
SlurmResumeJob(**job)raisedTypeError: unexpected keyword argument 'exclusive', which failed the whole resume. As a result, ParallelCluster could not launch dynamic nodes with Slurm 26.05.This commit:
exclusiveandpriority, and ignores any key a future Slurm adds, so new Resume File fields no longer break scaling.SlurmResumeJob.is_exclusive(). It had no caller since [develop] Remove separation between oversubscribe and no-oversubscribe jobs #574 (job-level scaling for all jobs).Backward compatible: Slurm 25.11 doesn't emit either key, so both default to
Noneand parsing is unchanged.Note: this is an initial support for Slurm 26.05 to allow ParallelCluster scale correctly. This commit doesn't upgrade consider incorporating new Slurm features.
Tests
Build image is successful. The following tests have passed:
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.