Repository navigation
refactor(core): restructure core codebase - #277
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 190 files, which is 90 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (190)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…vtools, @tanstack/react-router-ssr-query, @tanstack/react-start, @tanstack/router-plugin to ^1.170.41, ^1.167.0, ^1.167.3, ^1.168.60, ^1.168.42
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| headers: { Referer: "https://app.example.com/dashboard" }, | ||
| }) | ||
| const redirectTo = await createRedirectTo(request, undefined, { | ||
| trustedOrigins: ["https://*.example.com"], |
| test("with trusted origins that are not same origin", async () => { | ||
| const request = new Request("https://example.com/auth/signIn/github") | ||
| const redirectTo = await createRedirectTo(request, "https://api.example.com/redirect", { | ||
| trustedOrigins: ["https://api.example.com"], |
| test("with wildcard pattern and subdomain and valid origin", async () => { | ||
| const request = new Request("https://app.example.com/auth/signIn/github") | ||
| const redirectTo = await createRedirectTo(request, "https://app.example.com/dashboard", { | ||
| trustedOrigins: ["https://*.example.com"], |
| test("with wildcard pattern and subdomain with invalid redirect value", async () => { | ||
| const request = new Request("https://app.example.com/auth/signIn/github") | ||
| const redirectTo = await createRedirectTo(request, "https://malicious.com/phishing", { | ||
| trustedOrigins: ["https://*.example.com"], |
| }, | ||
| }) | ||
| const redirectTo = await createRedirectTo(request, "https://evil.app.example.com/dashboard", { | ||
| trustedOrigins: ["https://*.example.com"], |
| }, | ||
| }) | ||
| const redirectTo = await createRedirectTo(request, "https://evil.example.com/dashboard", { | ||
| trustedOrigins: ["https://*.example.com"], |
| }, | ||
| }) | ||
| const redirectTo = await createRedirectTo(request, "https://evil.example.com/dashboard", { | ||
| trustedOrigins: ["https://*.example.com"], |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the core package by splitting logic into dedicated files and extracting shared functionality where appropriate.
The goal is to reduce files containing multiple unrelated responsibilities, improve code organization, and make the test suite easier to maintain by grouping related logic together.
Key Changes
configfolder for initial configuration-related logic.sharedinto a dedicatederrorsfolder.oauth/index.tsand improved its organization.