Repository navigation
Validate link proofs - #99
Merged
Merged
Conversation
validate_link_proof() had its signature check stubbed to false, so a proof for a packet sent over a link was never accepted. The packet was never marked delivered and its delivery callback never ran. This restores the check from the Python reference. link is passed as const Link& but Link::validate() isn't const, so it validates through a copy of the link (copies share the same state). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rUgoKJdB4U8fNS9HybY8S
Owner
|
Thanks for tracking this down and fixing it. The check was stubbed out in the port and I don't recall a deliberate reason, so restoring it from the reference looks right. Testing against Python RNS nodes over LoRa is useful confirmation. If you have time, a small test that a valid link proof marks the receipt delivered and a bad signature doesn't would be welcome. It isn't blocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_link_proof()had its signature check stubbed tofalse, so a proof for a packet sent over a link was never accepted. The packet was never marked delivered and its delivery callback would never run.This restores the check (from the Python reference).
Link::validate()isn't const, so it validates even through a copy of the link, which shares the same state.Restoring the check works in my testing. Was there a reason it was disabled?
Testing: running in SolarOS on a ThinkNode M9 (ESP32-S3, ESP-IDF) against Python RNS nodes over LoRa, exchanging LXMF messages. Native tests pass, and the series builds for
ttgo-lora32-v21andwiscore_rak4631.