Repository navigation
Include stdint.h in Utilities/Memory.h - #90
Merged
Merged
Conversation
Memory.h uses uint8_t/uint32_t/uint64_t without including <stdint.h>; native builds with GCC 15 fail with "'uint8_t' does not name a type". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for tracking this down and for including the exact GCC 15 error. Adding The CI run on this PR didn't start (0 jobs), so I'll re-trigger it. If it comes back green on the native and embedded builds, it looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/microReticulum/Utilities/Memory.husesuint8_t,uint32_tanduint64_twithout including<stdint.h>. With GCC 15 (Ubuntu 26.04,pio test -e native-local), every native build that pulls in this header fails:Older toolchains happened to get the typedefs through another header.
Change
Add
#include <stdint.h>toMemory.h. No functional change.Testing
pio test -e native-localfortest_crypto,test_transport,test_rns_loopback,test_bytes,test_generalnow build and pass.ttgo-lora32-v21) and nRF52 builds are unaffected (the include is a no-op where the types were already visible).🤖 Generated with Claude Code