Repository navigation
Add Destination::set_default_app_data() - #104
Merged
attermann merged 1 commit intoNov 10, 2026
Merged
Conversation
Destination::announce() already falls back to _default_app_data when it is called without app_data, but nothing could set it. Announces sent in answer to path requests (Transport calls announce() with empty app_data) therefore never carried app_data, so a NomadNet node reached through a path response showed up in clients as "Peer <hash>" instead of by name. Add set_default_app_data() and clear_default_app_data(), matching the Python RNS Destination API. Tested on an nRF52840 (MASN V1.2) running microReticulum_Firmware: with the node name set as default app_data, clients on another interface show the NomadNet node by name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks for this, and for the clear write-up of the path-response symptom. Having the setter is overdue, since It's small, matches the Python API, and CI is green. One optional follow-up: a small test that checks an announce with no app_data picks up the default would help. It doesn't need to block this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Destination::announce()already falls back to_default_app_datawhen it is called without app_data, but there is no way to set it. Announces sent in answer to path requests (Transportcallsannounce()with empty app_data) therefore never carry app_data. A NomadNet node reached through a path response, typically from another interface or via a transport node, shows up in clients as "Peer " instead of by name.Change
Add
Destination::set_default_app_data()andclear_default_app_data(), matching the Python RNSDestinationAPI. No behaviour changes unless an application sets a default.Tested
Used by attermann/microReticulum_Firmware#123, which calls it only when the library provides it, so the firmware builds either way.
🤖 Generated with Claude Code