Repository navigation
Additional integer overflow fixes, follow-up to #281 - #290
Merged
Merged
Conversation
Due to towncrier misconfiguration.
There were a few other places where integers could overflow and wrap, at least given pathological data. Rather than keep reinventing the wheel on this, adds new `asdf_uint64_(add/mul)_sat` utilities for saturating towards UINT64_MAX instead of wrapping. Could be useful in other cases like this if we remember to use them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #289. Also noticed a stray line in
src/block.cleft over from my bungled merge conflict resolution in #284, and while testing release noticed that the changelog entries have wrong GitHub issue links.AI Disclosure
No AI used.