Skip to content

Restructure ArgoCD options into managedArgo / inClusterArgo - #148

Merged
ArnobKumarSaha merged 1 commit into
masterfrom
arnob-argo-opts
Nov 4, 2026
Merged

ArnobKumarSaha merged 1 commit into
masterfrom
arnob-argo-opts

Conversation

@ArnobKumarSaha

Copy link
Copy Markdown
Member

Restructures ArgoCDOptions in apis/config/v1alpha1 (selfManagement.argoCD) and apis/cluster:

type ArgoCDOptions struct {
	Enabled       bool
	ManagedArgo   *ManagedArgo   // existingKubeconfig, argoCDClusterName, namespace
	InClusterArgo *InClusterArgo // deployPrincipal, principalServiceType
}
  • apis/cluster.ArgoCDOptions keeps principalClusterName at the top level.
  • ExistingClusterName is removed. Managed mode now means managedArgo.existingKubeconfig is set.
  • argoCDClusterName is the name this cluster is registered under inside the existing Argo CD. It becomes fargocd's clusterName/destName.
  • Breaking change: the old flat fields are not accepted.

Note: zz_generated.deepcopy.go was written by hand; please re-run make gen.

Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
@ArnobKumarSaha
ArnobKumarSaha merged commit a20a8ea into master Nov 4, 2026
4 checks passed
@ArnobKumarSaha
ArnobKumarSaha deleted the arnob-argo-opts branch November 4, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant